This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Replace a Map of LogSources with a List of LogSources #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Nov 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
- Coverage 67.01% 66.92% -0.09%
==========================================
Files 37 37
Lines 2689 2670 -19
==========================================
- Hits 1802 1787 -15
+ Misses 583 581 -2
+ Partials 304 302 -2
Continue to review full report at Codecov.
|
* 'meta' of github.com:gdbelvin/keytransparency: Read map at a specific revision (google#1118)
|
|
pav-kv
reviewed
Nov 26, 2018
|
There are some other "shard" mentionings left from the previous code. Find&replace them with "slice index" to be consistent please. |
* master: Define LogMapFn as it currently exists (google#1126)
* master: Simplify the Reduce function interface (google#1127)
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Nov 26, 2018
* master: Replace a Map of LogSources with a List of LogSources (google#1124)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A list of
[]*spb.MapMetadata_SourceSliceis a lot easier to manage and iterate through thanmap[int64]*spb.MapMetadata_SourceSlice.beam.CreateList, unlike KeyValue pairs.SourcesEntrywhich are not protos and therefore will have trouble when it comes to serializing them for a map reduce.