This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
SECG1 Encode/Decode #1513
Merged
SECG1 Encode/Decode #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encode and Decode elliptic curve points in compressed format. This will be superceeded by golang/go#34105 in Go 1.15
golangcibot
reviewed
Apr 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
==========================================
+ Coverage 68.46% 68.59% +0.13%
==========================================
Files 54 55 +1
Lines 4011 4063 +52
==========================================
+ Hits 2746 2787 +41
- Misses 865 870 +5
- Partials 400 406 +6
Continue to review full report at Codecov.
|
golangcibot
reviewed
Apr 7, 2020
cindylindeed
approved these changes
Apr 7, 2020
| func secg1Decode(curve elliptic.Curve, data []byte) (x, y *big.Int) { | ||
| byteLen := (curve.Params().BitSize + 7) >> 3 | ||
| if (data[0] &^ 1) != 2 { | ||
| return // unrecognized point encoding |
There was a problem hiding this comment.
Would be better for these erroneous returns to be more descriptive, although I see that this function is a duplicate from elsewhere.
* master: Bump github.com/spf13/viper from 1.6.2 to 1.6.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode and Decode elliptic curve points in compressed format.
This will be superceeded by golang/go#34105 in
Go 1.15