Skip to content

Commit

Permalink
Revert PR: #1049 (#1063)
Browse files Browse the repository at this point in the history
PR: #1049 is breaking .net Core
applications, where lower case environment variables are expected.
Proposing this change, before better fix is available

<!-- Include the issue number below -->
Fixes #

## Proposed Changes

*
*
*

## Release Notes

<!-- kf follows the Keep A Changelog standard for release notes.

https://keepachangelog.com/en/1.0.0/

Changelog entries should be one per line and start with one of the
following
words:

`Added` for new features.
`Changed` for changes in existing functionality.
`Deprecated` for soon-to-be removed features.
`Removed` for now removed features.
`Fixed` for any bug fixes.
`Security` in case of vulnerabilities.

If one of the changes is breaking include that as a second word e.g.

  Removed BREAKING support for manifests v1
-->

```release-note

```
  • Loading branch information
skakauridze-clgx authored Nov 15, 2023
1 parent 01482b3 commit 6da8e18
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/kf/commands/apps/set_env.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package apps
import (
"context"
"fmt"
"strings"
"time"

v1alpha1 "github.com/google/kf/v2/pkg/apis/kf/v1alpha1"
Expand Down Expand Up @@ -65,7 +64,7 @@ func NewSetEnvCommand(p *config.KfParams, client apps.Client) *cobra.Command {
value := args[2]

toSet := []corev1.EnvVar{
{Name: strings.ToUpper(name), Value: value},
{Name: name, Value: value},
}

app, err := client.Transform(cmd.Context(), p.Space, appName, func(app *v1alpha1.App) error {
Expand Down

0 comments on commit 6da8e18

Please sign in to comment.