This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Ingress Readiness and Liveness check stop working after an upstream change #1973
Labels
area/broker
kind/bug
Something isn't working
priority/1
Blocks current release defined by release/* label or blocks current milestone
release/2
Milestone
Describe the bug
Ingress readiness and liveness (using kncloudevents library from eventing) check stop working after an upstream change: knative/eventing#3917
Expected behavior
A clear and concise description of what you expected to happen.
To Reproduce
change the following line to return
response.WriteHeader(nethttp.StatusMethodNotAllowed)
knative-gcp/pkg/broker/ingress/handler.go
Lines 123 to 125 in 544ec2d
It should fail the readiness and liveness check for the ingress pod, however, ingress pod will continue work.
Revert the upstream change, then return
response.WriteHeader(nethttp.StatusMethodNotAllowed)
, readiness and liveness check will work.Knative-GCP release version
Additional context
Add any other context about the problem here such as proposed priority
The text was updated successfully, but these errors were encountered: