message receiver supports customized liveness and readiness check #4707
Conversation
knative-prow-robot
added
the
size/M
|
/cc @Harwayne |
Codecov Report
@@ Coverage Diff @@
## master #4707 +/- ##
==========================================
- Coverage 81.07% 81.02% -0.05%
==========================================
Files 291 291
Lines 8216 8221 +5
==========================================
Hits 6661 6661
- Misses 1154 1159 +5
Partials 401 401
Continue to review full report at Codecov.
|
|
/assign |
There was a problem hiding this comment.
- Do you mind adding a release note to the PR description so that downstream developers know the new release added healthcheck draining to the HTTPMessageReceiver. You can find the template here
- Are there suggestions how to use the health checks for the core components? IMC, my-broker, sources, etc.?
- I presume you need this downstream somewhere, I'm interested to know the use case.
knative-prow-robot
added
needs-rebase
grac3gao-zz
force-pushed
the
addchecker
branch
from
57a8063 to
1fc3905
Compare
|
@grac3gao this needs rebase, lgtm now and thanks for adding those |
|
@devguyio has lgtm and this is just rebased. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grac3gao, zhongduo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/lgtm |
|
In order to align the deps for 0.20 release, I had to remove the change brought in by this PR #4724 Can you PR these changes again? |
So....it should be fine (doesn't have any alignment needs) if I submit a new PR to update deps after your PR #4724? @slinkydeveloper |
|
Yeah just go ahead and add again the code I removed targeting master and ping me in that PR, i'll merge it. Sorry for the inconvenient, seems like in this release process we cannot merge PRs with dep updates (except the automated ones) between the pkg cut and the eventing cut) |
|
@slinkydeveloper #4730 is for this PR, thank you! |
Fixes #
Proposed Changes
Message receiver uses Drainer to run liveness and readiness check. Previously, when the Pod is not in draining status, Drainer directly writes statusOK to kube probe request, without going through the inner handler logic. This makes any customized health check in inner handler useless.
Now that Drainer supports customized check, let message receiver support it as well. This would help users who want to use kn event message receiver and in the time want to configure their own check.
Release Note
Docs