Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #4724

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Updates #4724

merged 2 commits into from
Jan 12, 2021

Conversation

slinkydeveloper
Copy link
Contributor

Pre-release updates

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 12, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 12, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #4724 (f7ab865) into master (3f32d79) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4724      +/-   ##
==========================================
+ Coverage   81.02%   81.05%   +0.02%     
==========================================
  Files         291      291              
  Lines        8221     8218       -3     
==========================================
  Hits         6661     6661              
+ Misses       1159     1156       -3     
  Partials      401      401              
Impacted Files Coverage Δ
pkg/kncloudevents/message_receiver.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f32d79...ea9ed9c. Read the comment docs.

@vaikas
Copy link
Contributor

vaikas commented Jan 12, 2021

One kind tests that failed is something that we've seen (unrelated to this). Thought we had an existing issue, couldn't find it, so created this:
#4725

@vaikas
Copy link
Contributor

vaikas commented Jan 12, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants