Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

[master] Auto-update dependencies #1314

Conversation

mattmoor
Copy link
Contributor

Produced via:
./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh
/assign grantr ian-mi nachocano
/cc grantr ian-mi nachocano

Produced via:
  `./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh`
/assign grantr ian-mi nachocano
/cc grantr ian-mi nachocano
@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jun 19, 2020
@knative-prow-robot
Copy link
Contributor

Hi @mattmoor. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Contributor

@mattmoor: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-unit-tests 792d117 link /test pull-google-knative-gcp-unit-tests
pull-google-knative-gcp-integration-tests 792d117 link /test pull-google-knative-gcp-integration-tests
pull-google-knative-gcp-build-tests 792d117 link /test pull-google-knative-gcp-build-tests
pull-google-knative-gcp-wi-tests 792d117 link /test pull-google-knative-gcp-wi-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zargarpur
Copy link
Contributor

pkg/pubsub/publisher/publisher.go:51:23: undefined: kncloudevents.NewDefaultClient

Which was removed in knative/eventing with this change knative/eventing#3345

Looks like @nachocano is fixing that with #1296

@nachocano
Copy link
Member

Closing this one in favor of #1314

@nachocano nachocano closed this Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm ok-to-test size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants