Failed to upgrade to Kotlin 1.9

[hantsy]

I updated my project to Kotlin 1.9.0 and Gradle 8.2, and got the following build info.

A problem was found with the configuration of task ':kaptGenerateStubsKotlin' (type 'KaptGenerateStubsTask').
  - Gradle detected a problem with the following location: 'D:\FreelanceProjects\sami\etip-backend\build\generated\ksp\main\kotlin'.

    Reason: Task ':kaptGenerateStubsKotlin' uses this output of task ':kspKotlin' without declaring an explicit or implicit dependency. This can lead to incorrect results being produce
d, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':kspKotlin' as an input of ':kaptGenerateStubsKotlin'.
      2. Declare an explicit dependency on ':kspKotlin' from ':kaptGenerateStubsKotlin' using Task#dependsOn.

Add the following in the build.gradle.kts, did not resolve the issue.

tasks.named("kaptGenerateStubsKotlin"){
    dependsOn("kspKotlin")
}

[ting-yuan]

Would you mind sharing a small reproducible test case?

[hantsy]

I am not sure if this is caused by KSP and Dataframe.

Add this to resolve our problem, our project used Kotlin Dataframe¹ which used Ksp in Dataframe codegen plugin.

tasks.whenTaskAdded {
    if (name == "kaptGenerateStubsKotlin") {
        dependsOn("kspKotlin")
    }
    if (name == "kaptTestKotlin") {
        dependsOn("kspTestKotlin")
    }

//...
}

Footnotes

1. https://github.com/Kotlin/dataframe ↩

[Enaium]

+1 same here

[uladzislau-hryshechka]

+1 same here. We have multimodule android project. We use kapt and ksp at same time. Maybe you could provide a temporary workaround to fix this issue? Thanks in advance! @ting-yuan

[uladzislau-hryshechka]

Temporary workaround which worked for us. If you use convention plugin:

pluginManager.withPlugin("com.google.devtools.ksp") {
        tasks.configureEach {
            if (name == "kaptGenerateStubsKotlin") {
                dependsOn("kspKotlin")
            }
            if (name == "kaptKotlin") {
                dependsOn("kspKotlin")
            }
        }
    }

If you don't use convention plugin, that works too. Add at the end of build.gradle.(kts) file:

tasks.configureEach {
        if (name == "kaptGenerateStubsKotlin") {
            dependsOn("kspKotlin")
        }
        if (name == "kaptKotlin") {
            dependsOn("kspKotlin")
        }
    }

[neetopia]

@Enaium @uladzislau-hryshechka can you provide mode details on how your project is configured? From @hantsy 's case, it does seem like applying dataframe added a dependency since dataframe generates code with KSP that might be taken as input to KAPT.

[brentwatson]

+1 experiencing the same in our project. Same workaround resolved this for us.

[Enaium]

@Enaium @uladzislau-hryshechka can you provide mode details on how your project is configured? From @hantsy 's case, it does seem like applying dataframe added a dependency since dataframe generates code with KSP that might be taken as input to KAPT.

https://github.com/babyfish-ct/jimmer/tree/main/example/kotlin/jimmer-sql-kt

kotlin("jvm") version "1.9.0"
kotlin("kapt") version "1.9.0"
kotlin("plugin.spring") version "1.9.0"
id("com.google.devtools.ksp") version "1.9.0-1.0.12"

[uladzislau-hryshechka]

@Enaium @uladzislau-hryshechka can you provide mode details on how your project is configured? From @hantsy 's case, it does seem like applying dataframe added a dependency since dataframe generates code with KSP that might be taken as input to KAPT.

We have multimodule android project. Structure of this project:

- kotlin library module
- android library module
- app module  (which include all android and kotlin libraries)

Some modules could include ksp, kapt, both or nothing of that. It depends. Classical type of plugins which we use (for example android library):

plugins {
  id("base.android") - our convention plugin 
  id("kotlin-kapt")
  id("com.google.devtools.ksp")
}

[ZacSweers]

I don't think this is a bug per-se, rather a side effect of kapt tasks no longer being eagerly initialized. I think the right solution would be for KSP to offer an API to add this dependency at the Gradle level.

Perhaps something like this? Or a gradle property?

ksp {
  makeKaptTasksDependOnKspTasks()
}

Where things get tricky are matching variants and KMP jvm source sets, but I think it'd be worthwhile to do.

[ting-yuan]

I guess some of the issues come from a previous workaround which lets IDE be aware of generated source:

kotlin {
	sourceSets.main {
		kotlin.srcDir("build/generated/ksp/main/kotlin")
	}
}

KSP has been doing this automatically, with dependencies correctly set up since 1.0.9. If you have this workaround in your build script, please try to remove it and see if the problem remains.

[Enaium]

I guess some of the issues come from a previous workaround which lets IDE be aware of generated source:

kotlin {
	sourceSets.main {
		kotlin.srcDir("build/generated/ksp/main/kotlin")
	}
}

KSP has been doing this automatically, with dependencies correctly set up since 1.0.9. If you have this workaround in your build script, please try to remove it and see if the problem remains.

But it still has problems after run the clean task

[ting-yuan]

Do you mean that, after removing that block / workaround and doing a clean build, the problem remains? If so, could you provide a sample project so that we can investigate?

[dimsuz]

I don't have the srcDirs workaround mentioned above, but still got this error after upgrading to kotlin 1.9.10 and the corresponding ksp version.

[Enaium]

I solved the issue.

The kapt plugin must be declared after the ksp plugin.

plugins {
kotlin("jvm") version "1.9.0"
-kotlin("kapt") version "1.9.0"
id("com.google.devtools.ksp") version "1.9.0-1.0.12"
+kotlin("kapt") version "1.9.0"
}

[shivam-gupta007]

I got this warning in upgrading to kotlin 1.9.10

ksp-1.8.10-1.0.9 is too old for kotlin-1.9.10. Please upgrade ksp or downgrade kotlin-gradle-plugin to 1.8.10.

is there any ksp version that is compatible with the kotlin 1.9.10

[neetopia]

I got this warning in upgrading to kotlin 1.9.10

ksp-1.8.10-1.0.9 is too old for kotlin-1.9.10. Please upgrade ksp or downgrade kotlin-gradle-plugin to 1.8.10.

is there any ksp version that is compatible with the kotlin 1.9.10

you can try KSP 1.9.10-1.0.13

[shivam-gupta007]

Thanks @neetopia 🙌🙌

[Lysander]

Maybe my comment could help you: #963 (comment)