#1232: Include type hint into KSErrorType. #1848

Jeffset · 2024-04-18T17:43:25Z

This CL makes KSErrorType a class with a string
"hint", that by convention should be a "simpleName" of an unresolved type.

KSErrorTypeClassDeclaration is also no longer a singleton and references a corresponding KSErrorType.

The implementation consists of extracting the available info on the unresolved type on the best effort basis.

Resolves #1232

Changes for the clients

if isError is true for a type, then the toString() for the type will "likely" return a meaningful value in a format of "<ERROR TYPE: SomeSimpleName>", of <ERROR TYPE> (as before) if no info was available.
KSErrorType and their synthetic declarations will now be separate instances.

This is the first iteration; if API changes are needed and/or other issues are uncovered, I'm ready to work on them. If my approach to solving the original issue is presumed to be OK, I may write more tests for error types in addition to the existing ones.

google-cla · 2024-04-18T17:43:31Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Jeffset · 2024-04-18T19:22:06Z

compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt

@@ -1257,16 +1258,18 @@ class ResolverImpl(
                argument.projectionKind != org.jetbrains.kotlin.types.Variance.INVARIANT
            ) {
                // conflicting variances
-                // TODO: error message
-                return null
+                throw IllegalArgumentException(


I took liberty in making this an exception. My argument is that returning an error type in a situation seemingly close to an internal error is a bit weird, maybe it's better to crash. If we are not ready to make such decision here, please tell me, and I'll revert to returning null and later on an error type.

Conflicting variance might come from incorrectly defined classes and types applications which should be error types to make more sense as it is user input error rather than the compiler internal error. I think your error message below is good though, so maybe adding it to the hint since the hint is for easier error understanding anyways?

Jeffset · 2024-04-18T19:27:54Z

...sis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSClassDeclarationImpl.kt

@@ -125,7 +125,7 @@ class KSClassDeclarationImpl private constructor(internal val ktClassOrObjectSym

    override fun asType(typeArguments: List<KSTypeArgument>): KSType {
        if (typeArguments.isNotEmpty() && typeArguments.size != asStarProjectedType().arguments.size) {
-            return KSErrorType
+            return KSErrorType()


In this (and similar) cases, where an error type is used to signal the incorrect API usage rather than to represent a truly missing/unresolved type, I've decided to not provide any additional hints. If that's not okay or if I've misinterpreted something, let's discuss the matter.

Jeffset · 2024-05-02T17:42:13Z

@neetopia @ting-yuan I wonder if we are ready to discuss the solution, if not, please let me know.

neetopia

overall looks good, please take a look at the comments and let me know what you think. Also please resolve the conflicts.

There are a couple of KSErrorTypes without hint filled in, can you please also address them? I did not comment all of them to avoid spamming comments.

neetopia · 2024-05-28T21:56:12Z

...pi/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSErrorTypeClassDeclaration.kt

+        return this === other || other is KSErrorTypeClassDeclaration && other.type == type
+    }
+
+    override fun hashCode(): Int = type.hashCode()


maybe add some salt to this hashcode so that we won't always get hash collision for the type and the declaration?

neetopia · 2024-05-28T23:40:09Z

kotlin-analysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSTypeImpl.kt

    }

    override fun starProjection(): KSType {
        return type.replace(List(type.typeArguments().size) { KtStarTypeProjection(type.token) })
-            ?.let { getCached(it) } ?: KSErrorType
+            ?.let { getCached(it) } ?: KSErrorType()


should we add something to replace type arguments use case? This is not helping with error types.

I've tried to generalize the error type creation in such cases and introduced an errorTypeOnInconsistentArguments utility function which is now used in the old and AA impls. This pretty much covers all unfilled error types, except some where there's really nothing meaningful to report.

neetopia · 2024-05-28T23:41:40Z

...in/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/resolved/KSTypeReferenceResolvedImpl.kt

+            KSErrorType(
+                when (ktType) {
+                    is KtClassErrorType -> ktType.getNameHint()
+                    is KtTypeErrorType -> null // No info available


we can look at the parent for possible information, you can ignore this comment if it is too much work for you.

I've noticed that when there's some type information (at least an identifier, or even identifier matched with an import/qualified identifier) then we get a KtClassErrorType which is good. When the type is simply missing altogether - we get KtTypeErrorType. Nevertheless I've used KtTypeErrorType.tryRenderAsNonErrorType as a last resort, as some info may still be available though there. The place where we handle AA's error types is now KtType.render() function for consistency.

neetopia · 2024-05-28T23:43:51Z

compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt

@@ -691,7 +691,8 @@ class ResolverImpl(
                builtIns.arrayType.replace(typeArgs)
            }
            else -> {
-                getClassDeclarationByName(psiType.canonicalText)?.asStarProjectedType() ?: KSErrorType
+                getClassDeclarationByName(psiType.canonicalText)?.asStarProjectedType()
+                    ?: KSErrorType(psiType.canonicalText)


Any specific reason to use canonical text? I think you are using simple names for implementations in analysis api?

Yes, the idea is to try including as much type information as available. If additional qualifiers are resolved by the compiler - include them. I guess you're right about the things I did in AA, so I went and tried to use qualified names there as well. See KtType.render() -> KtClassErrorType.qualifiers

neetopia · 2024-05-28T23:45:48Z

compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt

@@ -1257,16 +1258,18 @@ class ResolverImpl(
                argument.projectionKind != org.jetbrains.kotlin.types.Variance.INVARIANT
            ) {
                // conflicting variances
-                // TODO: error message
-                return null
+                throw IllegalArgumentException(


Conflicting variance might come from incorrectly defined classes and types applications which should be error types to make more sense as it is user input error rather than the compiler internal error. I think your error message below is good though, so maybe adding it to the hint since the hint is for easier error understanding anyways?

neetopia · 2024-05-28T23:46:49Z

compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt

-                // Type projection isn't allowed in immediate arguments to supertypes.
-                // TODO: error message
-                return KSTypeReferenceSyntheticImpl.getCached(KSErrorType, null)
+                throw IllegalArgumentException("Type projection isn't allowed in immediate arguments to supertypes")


neetopia · 2024-05-28T23:48:08Z

...c/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSClassDeclarationDescriptorImpl.kt

@@ -153,7 +153,7 @@ class KSClassDeclarationDescriptorImpl private constructor(val descriptor: Class
    override fun asType(typeArguments: List<KSTypeArgument>): KSType =
        descriptor.defaultType.replaceTypeArguments(typeArguments)?.let {
            getKSTypeCached(it, typeArguments)
-        } ?: KSErrorType
+        } ?: KSErrorType()


include the original text for the type?

This CL makes `KSErrorType` a class with a string "hint", that by convention should be a "simpleName" of an unresolved type. `KSErrorTypeClassDeclaration` is also no longer a singleton and references a corresponding `KSErrorType`. The implementation consists of extracting the available info on the unresolved type on the best effort basis.

Allow KSErrorType to receive a message as additional piece of information on why a valid type can't be provided. Cover `replace`/`asType` cases with a utility function `errorTypeOnInconsistentArguments` to get consistent error messages across implementations. Tweak KSTypeImpl.isError detection in AA, move TODO there.

Jeffset · 2024-06-01T10:56:28Z

I resolved the conflicts in the first commit with minimal changes. All the additional fixes and requested review changes are in the second commit for more convenience.

neetopia

thanks for the work!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.devtools.ksp](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.devtools.ksp/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.devtools.ksp/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/ksp (com.google.devtools.ksp)</summary> ### [`v2.0.0-1.0.22`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.22) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.21...2.0.0-1.0.22) #### Important Changes - `KSErrorType.toString()` now contains the reference name it was tried to be resolved, and therefore `KSErrorType` is no longer a singleton. Processors relying on equality checks of that (in contrast of using `KSType.isError`) will need to be updated accordingly. #### Issues Fixed [#1908](https://togithub.com/google/ksp/issues/1908) KSP2: Calling KSP2 in programs does not appear to work on macOS or Windows [#1917](https://togithub.com/google/ksp/issues/1917) KSP2's symbol-processing-aa-embeddable artifact exposes an unresolvable pre-release kotlin 2.0.20 dependency [#1911](https://togithub.com/google/ksp/issues/1911) NoSuchMethodError when running KSP2 with Dagger (KSP 2.0.0-1.0.21) [#1909](https://togithub.com/google/ksp/issues/1909) KSP2: default annotation arguments no longer work in 1.0.21 [#1232](https://togithub.com/google/ksp/issues/1232) Expose simple names on a missing types's synthetic declaration [#1857](https://togithub.com/google/ksp/issues/1857) \[KSP2] Modifiers are missing for property accessors [#1924](https://togithub.com/google/ksp/issues/1924) \[KSP2] Type arg becomes '\*' after calling KSType.replace() with an error type [#1948](https://togithub.com/google/ksp/issues/1948) KSP2 default annotation KClass values for built-in types use java.lang.\* versions #### What's Changed - Include type hint into KSErrorType. by [@Jeffset](https://togithub.com/Jeffset) in [https://github.com/google/ksp/pull/1848](https://togithub.com/google/ksp/pull/1848) - Implement Resolver.getModuleName API by [@ZacSweers](https://togithub.com/ZacSweers) in [https://github.com/google/ksp/pull/1847](https://togithub.com/google/ksp/pull/1847) - Patch AA service files in renamed uber jar by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1867](https://togithub.com/google/ksp/pull/1867) - fix annotation default value parsing for arrays and class literals. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1871](https://togithub.com/google/ksp/pull/1871) - fix package name for library based symbols by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1873](https://togithub.com/google/ksp/pull/1873) - Do not index classpath in declaration provider by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1870](https://togithub.com/google/ksp/pull/1870) - check functional interface for modifiers by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1872](https://togithub.com/google/ksp/pull/1872) - Annotation default java by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1879](https://togithub.com/google/ksp/pull/1879) - fix type parameter bounds by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1880](https://togithub.com/google/ksp/pull/1880) - Add command line parser and entry points by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1885](https://togithub.com/google/ksp/pull/1885) - KSP2: Fix support of wasm by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1888](https://togithub.com/google/ksp/pull/1888) - Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1881](https://togithub.com/google/ksp/pull/1881) - Reuse Kotlin indexes in incremental providers by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1891](https://togithub.com/google/ksp/pull/1891) - special handling for java property accessors override checking by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1894](https://togithub.com/google/ksp/pull/1894) - KSP2: Reuse Java indexes by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1895](https://togithub.com/google/ksp/pull/1895) - Incremental: fix roots from getSealedSubclasses by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1893](https://togithub.com/google/ksp/pull/1893) - use safe cast for annotation type to declaration resolution by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1902](https://togithub.com/google/ksp/pull/1902) **Full Changelog**: google/ksp@2.0.0-1.0.21...2.0.0-1.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ZacSweers/CatchUp).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.devtools.ksp](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.devtools.ksp/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.devtools.ksp/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/ksp (com.google.devtools.ksp)</summary> ### [`v2.0.0-1.0.22`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.22) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.21...2.0.0-1.0.22) #### Important Changes - `KSErrorType.toString()` now contains the reference name it was tried to be resolved, and therefore `KSErrorType` is no longer a singleton. Processors relying on equality checks of that (in contrast of using `KSType.isError`) will need to be updated accordingly. #### Issues Fixed [#1908](https://togithub.com/google/ksp/issues/1908) KSP2: Calling KSP2 in programs does not appear to work on macOS or Windows [#1917](https://togithub.com/google/ksp/issues/1917) KSP2's symbol-processing-aa-embeddable artifact exposes an unresolvable pre-release kotlin 2.0.20 dependency [#1911](https://togithub.com/google/ksp/issues/1911) NoSuchMethodError when running KSP2 with Dagger (KSP 2.0.0-1.0.21) [#1909](https://togithub.com/google/ksp/issues/1909) KSP2: default annotation arguments no longer work in 1.0.21 [#1232](https://togithub.com/google/ksp/issues/1232) Expose simple names on a missing types's synthetic declaration [#1857](https://togithub.com/google/ksp/issues/1857) \[KSP2] Modifiers are missing for property accessors [#1924](https://togithub.com/google/ksp/issues/1924) \[KSP2] Type arg becomes '\*' after calling KSType.replace() with an error type [#1948](https://togithub.com/google/ksp/issues/1948) KSP2 default annotation KClass values for built-in types use java.lang.\* versions #### What's Changed - Include type hint into KSErrorType. by [@Jeffset](https://togithub.com/Jeffset) in [https://github.com/google/ksp/pull/1848](https://togithub.com/google/ksp/pull/1848) - Implement Resolver.getModuleName API by [@ZacSweers](https://togithub.com/ZacSweers) in [https://github.com/google/ksp/pull/1847](https://togithub.com/google/ksp/pull/1847) - Patch AA service files in renamed uber jar by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1867](https://togithub.com/google/ksp/pull/1867) - fix annotation default value parsing for arrays and class literals. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1871](https://togithub.com/google/ksp/pull/1871) - fix package name for library based symbols by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1873](https://togithub.com/google/ksp/pull/1873) - Do not index classpath in declaration provider by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1870](https://togithub.com/google/ksp/pull/1870) - check functional interface for modifiers by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1872](https://togithub.com/google/ksp/pull/1872) - Annotation default java by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1879](https://togithub.com/google/ksp/pull/1879) - fix type parameter bounds by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1880](https://togithub.com/google/ksp/pull/1880) - Add command line parser and entry points by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1885](https://togithub.com/google/ksp/pull/1885) - KSP2: Fix support of wasm by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1888](https://togithub.com/google/ksp/pull/1888) - Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1881](https://togithub.com/google/ksp/pull/1881) - Reuse Kotlin indexes in incremental providers by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1891](https://togithub.com/google/ksp/pull/1891) - special handling for java property accessors override checking by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1894](https://togithub.com/google/ksp/pull/1894) - KSP2: Reuse Java indexes by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1895](https://togithub.com/google/ksp/pull/1895) - Incremental: fix roots from getSealedSubclasses by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1893](https://togithub.com/google/ksp/pull/1893) - use safe cast for annotation type to declaration resolution by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1902](https://togithub.com/google/ksp/pull/1902) **Full Changelog**: google/ksp@2.0.0-1.0.21...2.0.0-1.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tuskyapp/Tusky).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.devtools.ksp](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.devtools.ksp/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.devtools.ksp/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/ksp (com.google.devtools.ksp)</summary> ### [`v2.0.0-1.0.22`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.22) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.21...2.0.0-1.0.22) #### Important Changes - `KSErrorType.toString()` now contains the reference name it was tried to be resolved, and therefore `KSErrorType` is no longer a singleton. Processors relying on equality checks of that (in contrast of using `KSType.isError`) will need to be updated accordingly. #### Issues Fixed [#1908](https://togithub.com/google/ksp/issues/1908) KSP2: Calling KSP2 in programs does not appear to work on macOS or Windows [#1917](https://togithub.com/google/ksp/issues/1917) KSP2's symbol-processing-aa-embeddable artifact exposes an unresolvable pre-release kotlin 2.0.20 dependency [#1911](https://togithub.com/google/ksp/issues/1911) NoSuchMethodError when running KSP2 with Dagger (KSP 2.0.0-1.0.21) [#1909](https://togithub.com/google/ksp/issues/1909) KSP2: default annotation arguments no longer work in 1.0.21 [#1232](https://togithub.com/google/ksp/issues/1232) Expose simple names on a missing types's synthetic declaration [#1857](https://togithub.com/google/ksp/issues/1857) \[KSP2] Modifiers are missing for property accessors [#1924](https://togithub.com/google/ksp/issues/1924) \[KSP2] Type arg becomes '\*' after calling KSType.replace() with an error type [#1948](https://togithub.com/google/ksp/issues/1948) KSP2 default annotation KClass values for built-in types use java.lang.\* versions #### What's Changed - Include type hint into KSErrorType. by [@Jeffset](https://togithub.com/Jeffset) in [https://github.com/google/ksp/pull/1848](https://togithub.com/google/ksp/pull/1848) - Implement Resolver.getModuleName API by [@ZacSweers](https://togithub.com/ZacSweers) in [https://github.com/google/ksp/pull/1847](https://togithub.com/google/ksp/pull/1847) - Patch AA service files in renamed uber jar by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1867](https://togithub.com/google/ksp/pull/1867) - fix annotation default value parsing for arrays and class literals. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1871](https://togithub.com/google/ksp/pull/1871) - fix package name for library based symbols by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1873](https://togithub.com/google/ksp/pull/1873) - Do not index classpath in declaration provider by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1870](https://togithub.com/google/ksp/pull/1870) - check functional interface for modifiers by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1872](https://togithub.com/google/ksp/pull/1872) - Annotation default java by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1879](https://togithub.com/google/ksp/pull/1879) - fix type parameter bounds by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1880](https://togithub.com/google/ksp/pull/1880) - Add command line parser and entry points by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1885](https://togithub.com/google/ksp/pull/1885) - KSP2: Fix support of wasm by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1888](https://togithub.com/google/ksp/pull/1888) - Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1881](https://togithub.com/google/ksp/pull/1881) - Reuse Kotlin indexes in incremental providers by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1891](https://togithub.com/google/ksp/pull/1891) - special handling for java property accessors override checking by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1894](https://togithub.com/google/ksp/pull/1894) - KSP2: Reuse Java indexes by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1895](https://togithub.com/google/ksp/pull/1895) - Incremental: fix roots from getSealedSubclasses by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1893](https://togithub.com/google/ksp/pull/1893) - use safe cast for annotation type to declaration resolution by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1902](https://togithub.com/google/ksp/pull/1902) **Full Changelog**: google/ksp@2.0.0-1.0.21...2.0.0-1.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/WhosNickDoglio/dagger-rules).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.devtools.ksp](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | plugin | patch | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | | [com.google.devtools.ksp:symbol-processing-api](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | dependencies | patch | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | | [com.google.devtools.ksp:symbol-processing](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | dependencies | patch | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/ksp (com.google.devtools.ksp)</summary> ### [`v2.0.0-1.0.22`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.22) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.21...2.0.0-1.0.22) ##### Important Changes - `KSErrorType.toString()` now contains the reference name it was tried to be resolved, and therefore `KSErrorType` is no longer a singleton. Processors relying on equality checks of that (in contrast of using `KSType.isError`) will need to be updated accordingly. ##### Issues Fixed [#1908](https://togithub.com/google/ksp/issues/1908) KSP2: Calling KSP2 in programs does not appear to work on macOS or Windows [#1917](https://togithub.com/google/ksp/issues/1917) KSP2's symbol-processing-aa-embeddable artifact exposes an unresolvable pre-release kotlin 2.0.20 dependency [#1911](https://togithub.com/google/ksp/issues/1911) NoSuchMethodError when running KSP2 with Dagger (KSP 2.0.0-1.0.21) [#1909](https://togithub.com/google/ksp/issues/1909) KSP2: default annotation arguments no longer work in 1.0.21 [#1232](https://togithub.com/google/ksp/issues/1232) Expose simple names on a missing types's synthetic declaration [#1857](https://togithub.com/google/ksp/issues/1857) \[KSP2] Modifiers are missing for property accessors [#1924](https://togithub.com/google/ksp/issues/1924) \[KSP2] Type arg becomes '\*' after calling KSType.replace() with an error type [#1948](https://togithub.com/google/ksp/issues/1948) KSP2 default annotation KClass values for built-in types use java.lang.\* versions ##### What's Changed - Include type hint into KSErrorType. by [@Jeffset](https://togithub.com/Jeffset) in [https://github.com/google/ksp/pull/1848](https://togithub.com/google/ksp/pull/1848) - Implement Resolver.getModuleName API by [@ZacSweers](https://togithub.com/ZacSweers) in [https://github.com/google/ksp/pull/1847](https://togithub.com/google/ksp/pull/1847) - Patch AA service files in renamed uber jar by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1867](https://togithub.com/google/ksp/pull/1867) - fix annotation default value parsing for arrays and class literals. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1871](https://togithub.com/google/ksp/pull/1871) - fix package name for library based symbols by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1873](https://togithub.com/google/ksp/pull/1873) - Do not index classpath in declaration provider by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1870](https://togithub.com/google/ksp/pull/1870) - check functional interface for modifiers by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1872](https://togithub.com/google/ksp/pull/1872) - Annotation default java by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1879](https://togithub.com/google/ksp/pull/1879) - fix type parameter bounds by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1880](https://togithub.com/google/ksp/pull/1880) - Add command line parser and entry points by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1885](https://togithub.com/google/ksp/pull/1885) - KSP2: Fix support of wasm by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1888](https://togithub.com/google/ksp/pull/1888) - Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1881](https://togithub.com/google/ksp/pull/1881) - Reuse Kotlin indexes in incremental providers by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1891](https://togithub.com/google/ksp/pull/1891) - special handling for java property accessors override checking by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1894](https://togithub.com/google/ksp/pull/1894) - KSP2: Reuse Java indexes by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1895](https://togithub.com/google/ksp/pull/1895) - Incremental: fix roots from getSealedSubclasses by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1893](https://togithub.com/google/ksp/pull/1893) - use safe cast for annotation type to declaration resolution by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1902](https://togithub.com/google/ksp/pull/1902) **Full Changelog**: google/ksp@2.0.0-1.0.21...2.0.0-1.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.devtools.ksp](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | plugin | patch | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | | [com.google.devtools.ksp:symbol-processing-gradle-plugin](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | dependencies | patch | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/ksp (com.google.devtools.ksp)</summary> ### [`v2.0.0-1.0.22`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.22) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.21...2.0.0-1.0.22) ##### Important Changes - `KSErrorType.toString()` now contains the reference name it was tried to be resolved, and therefore `KSErrorType` is no longer a singleton. Processors relying on equality checks of that (in contrast of using `KSType.isError`) will need to be updated accordingly. ##### Issues Fixed [#1908](https://togithub.com/google/ksp/issues/1908) KSP2: Calling KSP2 in programs does not appear to work on macOS or Windows [#1917](https://togithub.com/google/ksp/issues/1917) KSP2's symbol-processing-aa-embeddable artifact exposes an unresolvable pre-release kotlin 2.0.20 dependency [#1911](https://togithub.com/google/ksp/issues/1911) NoSuchMethodError when running KSP2 with Dagger (KSP 2.0.0-1.0.21) [#1909](https://togithub.com/google/ksp/issues/1909) KSP2: default annotation arguments no longer work in 1.0.21 [#1232](https://togithub.com/google/ksp/issues/1232) Expose simple names on a missing types's synthetic declaration [#1857](https://togithub.com/google/ksp/issues/1857) \[KSP2] Modifiers are missing for property accessors [#1924](https://togithub.com/google/ksp/issues/1924) \[KSP2] Type arg becomes '\*' after calling KSType.replace() with an error type [#1948](https://togithub.com/google/ksp/issues/1948) KSP2 default annotation KClass values for built-in types use java.lang.\* versions ##### What's Changed - Include type hint into KSErrorType. by [@Jeffset](https://togithub.com/Jeffset) in [https://github.com/google/ksp/pull/1848](https://togithub.com/google/ksp/pull/1848) - Implement Resolver.getModuleName API by [@ZacSweers](https://togithub.com/ZacSweers) in [https://github.com/google/ksp/pull/1847](https://togithub.com/google/ksp/pull/1847) - Patch AA service files in renamed uber jar by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1867](https://togithub.com/google/ksp/pull/1867) - fix annotation default value parsing for arrays and class literals. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1871](https://togithub.com/google/ksp/pull/1871) - fix package name for library based symbols by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1873](https://togithub.com/google/ksp/pull/1873) - Do not index classpath in declaration provider by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1870](https://togithub.com/google/ksp/pull/1870) - check functional interface for modifiers by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1872](https://togithub.com/google/ksp/pull/1872) - Annotation default java by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1879](https://togithub.com/google/ksp/pull/1879) - fix type parameter bounds by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1880](https://togithub.com/google/ksp/pull/1880) - Add command line parser and entry points by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1885](https://togithub.com/google/ksp/pull/1885) - KSP2: Fix support of wasm by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1888](https://togithub.com/google/ksp/pull/1888) - Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1881](https://togithub.com/google/ksp/pull/1881) - Reuse Kotlin indexes in incremental providers by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1891](https://togithub.com/google/ksp/pull/1891) - special handling for java property accessors override checking by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1894](https://togithub.com/google/ksp/pull/1894) - KSP2: Reuse Java indexes by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1895](https://togithub.com/google/ksp/pull/1895) - Incremental: fix roots from getSealedSubclasses by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1893](https://togithub.com/google/ksp/pull/1893) - use safe cast for annotation type to declaration resolution by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1902](https://togithub.com/google/ksp/pull/1902) **Full Changelog**: google/ksp@2.0.0-1.0.21...2.0.0-1.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

…22 (#316) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.devtools.ksp](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | `2.0.0-1.0.21` -> `2.0.0-1.0.22` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.devtools.ksp/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.devtools.ksp/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/ksp (com.google.devtools.ksp)</summary> ### [`v2.0.0-1.0.22`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.22) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.21...2.0.0-1.0.22) #### Important Changes - `KSErrorType.toString()` now contains the reference name it was tried to be resolved, and therefore `KSErrorType` is no longer a singleton. Processors relying on equality checks of that (in contrast of using `KSType.isError`) will need to be updated accordingly. #### Issues Fixed [#1908](https://togithub.com/google/ksp/issues/1908) KSP2: Calling KSP2 in programs does not appear to work on macOS or Windows [#1917](https://togithub.com/google/ksp/issues/1917) KSP2's symbol-processing-aa-embeddable artifact exposes an unresolvable pre-release kotlin 2.0.20 dependency [#1911](https://togithub.com/google/ksp/issues/1911) NoSuchMethodError when running KSP2 with Dagger (KSP 2.0.0-1.0.21) [#1909](https://togithub.com/google/ksp/issues/1909) KSP2: default annotation arguments no longer work in 1.0.21 [#1232](https://togithub.com/google/ksp/issues/1232) Expose simple names on a missing types's synthetic declaration [#1857](https://togithub.com/google/ksp/issues/1857) \[KSP2] Modifiers are missing for property accessors [#1924](https://togithub.com/google/ksp/issues/1924) \[KSP2] Type arg becomes '\*' after calling KSType.replace() with an error type [#1948](https://togithub.com/google/ksp/issues/1948) KSP2 default annotation KClass values for built-in types use java.lang.\* versions #### What's Changed - Include type hint into KSErrorType. by [@Jeffset](https://togithub.com/Jeffset) in [https://github.com/google/ksp/pull/1848](https://togithub.com/google/ksp/pull/1848) - Implement Resolver.getModuleName API by [@ZacSweers](https://togithub.com/ZacSweers) in [https://github.com/google/ksp/pull/1847](https://togithub.com/google/ksp/pull/1847) - Patch AA service files in renamed uber jar by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1867](https://togithub.com/google/ksp/pull/1867) - fix annotation default value parsing for arrays and class literals. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1871](https://togithub.com/google/ksp/pull/1871) - fix package name for library based symbols by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1873](https://togithub.com/google/ksp/pull/1873) - Do not index classpath in declaration provider by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1870](https://togithub.com/google/ksp/pull/1870) - check functional interface for modifiers by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1872](https://togithub.com/google/ksp/pull/1872) - Annotation default java by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1879](https://togithub.com/google/ksp/pull/1879) - fix type parameter bounds by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1880](https://togithub.com/google/ksp/pull/1880) - Add command line parser and entry points by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1885](https://togithub.com/google/ksp/pull/1885) - KSP2: Fix support of wasm by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1888](https://togithub.com/google/ksp/pull/1888) - Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1881](https://togithub.com/google/ksp/pull/1881) - Reuse Kotlin indexes in incremental providers by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1891](https://togithub.com/google/ksp/pull/1891) - special handling for java property accessors override checking by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1894](https://togithub.com/google/ksp/pull/1894) - KSP2: Reuse Java indexes by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1895](https://togithub.com/google/ksp/pull/1895) - Incremental: fix roots from getSealedSubclasses by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1893](https://togithub.com/google/ksp/pull/1893) - use safe cast for annotation type to declaration resolution by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1902](https://togithub.com/google/ksp/pull/1902) **Full Changelog**: google/ksp@2.0.0-1.0.21...2.0.0-1.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arrow-kt/arrow-website).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.devtools.ksp](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | `2.0.0-1.0.21` -> `2.0.0-1.0.23` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.devtools.ksp/2.0.0-1.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.devtools.ksp/2.0.0-1.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/ksp (com.google.devtools.ksp)</summary> ### [`v2.0.0-1.0.23`](https://togithub.com/google/ksp/compare/2.0.0-1.0.22...2.0.0-1.0.23) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.22...2.0.0-1.0.23) ### [`v2.0.0-1.0.22`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.22) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.21...2.0.0-1.0.22) #### Important Changes - `KSErrorType.toString()` now contains the reference name it was tried to be resolved, and therefore `KSErrorType` is no longer a singleton. Processors relying on equality checks of that (in contrast of using `KSType.isError`) will need to be updated accordingly. #### Issues Fixed [#1908](https://togithub.com/google/ksp/issues/1908) KSP2: Calling KSP2 in programs does not appear to work on macOS or Windows [#1917](https://togithub.com/google/ksp/issues/1917) KSP2's symbol-processing-aa-embeddable artifact exposes an unresolvable pre-release kotlin 2.0.20 dependency [#1911](https://togithub.com/google/ksp/issues/1911) NoSuchMethodError when running KSP2 with Dagger (KSP 2.0.0-1.0.21) [#1909](https://togithub.com/google/ksp/issues/1909) KSP2: default annotation arguments no longer work in 1.0.21 [#1232](https://togithub.com/google/ksp/issues/1232) Expose simple names on a missing types's synthetic declaration [#1857](https://togithub.com/google/ksp/issues/1857) \[KSP2] Modifiers are missing for property accessors [#1924](https://togithub.com/google/ksp/issues/1924) \[KSP2] Type arg becomes '\*' after calling KSType.replace() with an error type [#1948](https://togithub.com/google/ksp/issues/1948) KSP2 default annotation KClass values for built-in types use java.lang.\* versions #### What's Changed - Include type hint into KSErrorType. by [@Jeffset](https://togithub.com/Jeffset) in [https://github.com/google/ksp/pull/1848](https://togithub.com/google/ksp/pull/1848) - Implement Resolver.getModuleName API by [@ZacSweers](https://togithub.com/ZacSweers) in [https://github.com/google/ksp/pull/1847](https://togithub.com/google/ksp/pull/1847) - Patch AA service files in renamed uber jar by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1867](https://togithub.com/google/ksp/pull/1867) - fix annotation default value parsing for arrays and class literals. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1871](https://togithub.com/google/ksp/pull/1871) - fix package name for library based symbols by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1873](https://togithub.com/google/ksp/pull/1873) - Do not index classpath in declaration provider by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1870](https://togithub.com/google/ksp/pull/1870) - check functional interface for modifiers by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1872](https://togithub.com/google/ksp/pull/1872) - Annotation default java by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1879](https://togithub.com/google/ksp/pull/1879) - fix type parameter bounds by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1880](https://togithub.com/google/ksp/pull/1880) - Add command line parser and entry points by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1885](https://togithub.com/google/ksp/pull/1885) - KSP2: Fix support of wasm by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1888](https://togithub.com/google/ksp/pull/1888) - Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1881](https://togithub.com/google/ksp/pull/1881) - Reuse Kotlin indexes in incremental providers by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1891](https://togithub.com/google/ksp/pull/1891) - special handling for java property accessors override checking by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1894](https://togithub.com/google/ksp/pull/1894) - KSP2: Reuse Java indexes by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1895](https://togithub.com/google/ksp/pull/1895) - Incremental: fix roots from getSealedSubclasses by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1893](https://togithub.com/google/ksp/pull/1893) - use safe cast for annotation type to declaration resolution by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1902](https://togithub.com/google/ksp/pull/1902) **Full Changelog**: google/ksp@2.0.0-1.0.21...2.0.0-1.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ZacSweers/ZacSweers).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.devtools.ksp](https://goo.gle/ksp) ([source](https://togithub.com/google/ksp)) | `2.0.0-1.0.21` -> `2.0.0-1.0.23` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.devtools.ksp/2.0.0-1.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.devtools.ksp/2.0.0-1.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.devtools.ksp/2.0.0-1.0.21/2.0.0-1.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/ksp (com.google.devtools.ksp)</summary> ### [`v2.0.0-1.0.23`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.23) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.22...2.0.0-1.0.23) #### Issues fixed - \[KSP2] Nullable type arg type becomes non-null after replace() call [#1856](https://togithub.com/google/ksp/issues/1856) - Annotations on enum entires on K2 are missing [#1962](https://togithub.com/google/ksp/issues/1962) - Got IllegalStateException when calling replace() on error types [#1960](https://togithub.com/google/ksp/issues/1960) - \[KSP2] Resolver.getJvmCheckedException doesn't work on property accessors [#1900](https://togithub.com/google/ksp/issues/1900) - \[KSP2] Property getter JVM names in data classes become componentN instead of getXXX [#1958](https://togithub.com/google/ksp/issues/1958) - \[KSP2] Resolver.mapToJvmSignature doesn't unwrap inline classes [#1859](https://togithub.com/google/ksp/issues/1859) - \[KSP2] KSFunctionDeclaration.asMemberOf does not return correct types [#1919](https://togithub.com/google/ksp/issues/1919) - implement getOwnerJvmClassName [#1979](https://togithub.com/google/ksp/issues/1979) - \[KSP2] KSPropertyDeclaration.hasBackingField returns inconsistent results [#1939](https://togithub.com/google/ksp/issues/1939) - \[KSP2] Annotations on extension receivers are missing [#1899](https://togithub.com/google/ksp/issues/1899) ### [`v2.0.0-1.0.22`](https://togithub.com/google/ksp/releases/tag/2.0.0-1.0.22) [Compare Source](https://togithub.com/google/ksp/compare/2.0.0-1.0.21...2.0.0-1.0.22) #### Important Changes - `KSErrorType.toString()` now contains the reference name it was tried to be resolved, and therefore `KSErrorType` is no longer a singleton. Processors relying on equality checks of that (in contrast of using `KSType.isError`) will need to be updated accordingly. #### Issues Fixed [#1908](https://togithub.com/google/ksp/issues/1908) KSP2: Calling KSP2 in programs does not appear to work on macOS or Windows [#1917](https://togithub.com/google/ksp/issues/1917) KSP2's symbol-processing-aa-embeddable artifact exposes an unresolvable pre-release kotlin 2.0.20 dependency [#1911](https://togithub.com/google/ksp/issues/1911) NoSuchMethodError when running KSP2 with Dagger (KSP 2.0.0-1.0.21) [#1909](https://togithub.com/google/ksp/issues/1909) KSP2: default annotation arguments no longer work in 1.0.21 [#1232](https://togithub.com/google/ksp/issues/1232) Expose simple names on a missing types's synthetic declaration [#1857](https://togithub.com/google/ksp/issues/1857) \[KSP2] Modifiers are missing for property accessors [#1924](https://togithub.com/google/ksp/issues/1924) \[KSP2] Type arg becomes '\*' after calling KSType.replace() with an error type [#1948](https://togithub.com/google/ksp/issues/1948) KSP2 default annotation KClass values for built-in types use java.lang.\* versions #### What's Changed - Include type hint into KSErrorType. by [@Jeffset](https://togithub.com/Jeffset) in [https://github.com/google/ksp/pull/1848](https://togithub.com/google/ksp/pull/1848) - Implement Resolver.getModuleName API by [@ZacSweers](https://togithub.com/ZacSweers) in [https://github.com/google/ksp/pull/1847](https://togithub.com/google/ksp/pull/1847) - Patch AA service files in renamed uber jar by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1867](https://togithub.com/google/ksp/pull/1867) - fix annotation default value parsing for arrays and class literals. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1871](https://togithub.com/google/ksp/pull/1871) - fix package name for library based symbols by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1873](https://togithub.com/google/ksp/pull/1873) - Do not index classpath in declaration provider by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1870](https://togithub.com/google/ksp/pull/1870) - check functional interface for modifiers by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1872](https://togithub.com/google/ksp/pull/1872) - Annotation default java by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1879](https://togithub.com/google/ksp/pull/1879) - fix type parameter bounds by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1880](https://togithub.com/google/ksp/pull/1880) - Add command line parser and entry points by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1885](https://togithub.com/google/ksp/pull/1885) - KSP2: Fix support of wasm by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1888](https://togithub.com/google/ksp/pull/1888) - Return KSClassDeclarationEnumEntryImpl for enum entry annotation values. by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1881](https://togithub.com/google/ksp/pull/1881) - Reuse Kotlin indexes in incremental providers by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1891](https://togithub.com/google/ksp/pull/1891) - special handling for java property accessors override checking by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1894](https://togithub.com/google/ksp/pull/1894) - KSP2: Reuse Java indexes by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1895](https://togithub.com/google/ksp/pull/1895) - Incremental: fix roots from getSealedSubclasses by [@ting-yuan](https://togithub.com/ting-yuan) in [https://github.com/google/ksp/pull/1893](https://togithub.com/google/ksp/pull/1893) - use safe cast for annotation type to declaration resolution by [@neetopia](https://togithub.com/neetopia) in [https://github.com/google/ksp/pull/1902](https://togithub.com/google/ksp/pull/1902) **Full Changelog**: google/ksp@2.0.0-1.0.21...2.0.0-1.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/simpledotorg/simple-android).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Sasikanth Miriyampalli <hello@sasikanth.dev>

Jeffset marked this pull request as ready for review April 18, 2024 18:22

Jeffset commented Apr 18, 2024

View reviewed changes

ting-yuan requested a review from neetopia May 28, 2024 21:30

neetopia reviewed May 28, 2024

View reviewed changes

Jeffset added 2 commits May 31, 2024 14:13

Jeffset force-pushed the wp/informative-error-types branch from fc18135 to ccfa177 Compare June 1, 2024 10:55

Jeffset requested a review from neetopia June 1, 2024 11:31

neetopia approved these changes Jun 3, 2024

View reviewed changes

neetopia merged commit 319ddff into google:main Jun 3, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1232: Include type hint into KSErrorType. #1848

#1232: Include type hint into KSErrorType. #1848

Jeffset commented Apr 18, 2024 •

edited

Loading

google-cla bot commented Apr 18, 2024

Jeffset Apr 18, 2024 •

edited

Loading

neetopia May 28, 2024

Jeffset Apr 18, 2024

Jeffset commented May 2, 2024

neetopia left a comment

neetopia May 28, 2024

neetopia May 28, 2024

Jeffset Jun 1, 2024

neetopia May 28, 2024

Jeffset Jun 1, 2024

neetopia May 28, 2024

Jeffset Jun 1, 2024

neetopia May 28, 2024

neetopia May 28, 2024

neetopia May 28, 2024

Jeffset commented Jun 1, 2024

neetopia left a comment

#1232: Include type hint into KSErrorType. #1848

#1232: Include type hint into KSErrorType. #1848

Conversation

Jeffset commented Apr 18, 2024 • edited Loading

Changes for the clients

google-cla bot commented Apr 18, 2024

Jeffset Apr 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jeffset commented May 2, 2024

neetopia left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jeffset commented Jun 1, 2024

neetopia left a comment

Choose a reason for hiding this comment

Jeffset commented Apr 18, 2024 •

edited

Loading

Jeffset Apr 18, 2024 •

edited

Loading