Skip to content

Fix ClassNotFoundException in case there are no SymbolProcessorProviders. #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kefirfromperm wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

Fix ClassNotFoundException in case there are no SymbolProcessorProviders. #2718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion gradle-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ dependencies {
// replace AGP dependency w/ gradle-api when we have source registering API available.
compileOnly("com.android.tools.build:gradle:$agpBaseVersion")
compileOnly(gradleApi())
compileOnly(project(":kotlin-analysis-api"))
// Ensure stdlib version is not inconsistent due to kotlin plugin version.
compileOnly(kotlin("stdlib", version = kotlinBaseVersion))
implementation(project(":api"))
Expand Down
10 changes: 7 additions & 3 deletions gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ package com.google.devtools.ksp.gradle
import com.google.devtools.ksp.gradle.utils.allKotlinSourceSetsObservable
import com.google.devtools.ksp.gradle.utils.canUseGeneratedKotlinApi
import com.google.devtools.ksp.gradle.utils.enableProjectIsolationCompatibleCodepath
import com.google.devtools.ksp.impl.KotlinSymbolProcessing
import com.google.devtools.ksp.processing.ExitCode
import com.google.devtools.ksp.processing.KSPCommonConfig
import com.google.devtools.ksp.processing.KSPConfig
Expand Down Expand Up @@ -584,8 +583,13 @@ abstract class KspAAWorkerAction : WorkAction<KspAAWorkParameter> {
val kspGradleLogger = KspGradleLogger(gradleCfg.logLevel.get().ordinal)

if (processorProviders.isEmpty()) {
kspGradleLogger.error("No providers found in processor classpath.")
throw Exception("KSP failed with exit code: ${KotlinSymbolProcessing.ExitCode.PROCESSING_ERROR}")
kspGradleLogger.error(
"No providers found in processor classpath.\n" +
"Make sure you have added KSP processor dependencies using 'ksp' configuration.\n" +
"Processors must implement com.google.devtools.ksp.processing.SymbolProcessorProvider and " +
"register the implementation via META-INF/services."
)
throw Exception("KSP failed with exit code: ${ExitCode.PROCESSING_ERROR}")
} else {
kspGradleLogger.info(
"loaded provider(s): " +
Expand Down