Add support for ast.IfExp #111
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| latex = r"\left\{ \begin{array}{ll} " | ||
| cond_latex = self.visit(node.test) | ||
| true_latex = self.visit(node.body) | ||
| false_latex = self.visit(node.orelse) |
There was a problem hiding this comment.
Note: I can make some follow-up pull requests for this comment.
I think this line does not process the recursion. e.g.:
if a:
return x
elif b:
return y
else:
return zand
return x if a else (y if b else z)should express the same logic, but this impl may generate a different result.
There was a problem hiding this comment.
I was able to process the recursion you highlighted, but wanted to know if we need to support recursion within both code blocks of the if then else statement like shown in the 2nd example.
There was a problem hiding this comment.
In visit_If the current implementation processes only the orelse subtree. I think we could choose the same behavior at this point.
|
Great work, thanks! |
|
Btw, CIs (Black and flake8) are still failing, I will merge this PR after resolving these issues. |
Overview
Add support for
a if x else b(ast.IfExp) statements.Details
References
Blocked by
NA