-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix brackets display #112
Merged
odashi
merged 13 commits into
google:main
from
jianan1104:add-mathopen-and-mathclose-to-parentheses
Nov 16, 2022
+203
−124
Merged
Fix brackets display #112
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bd3c52c
fix(function_codegen.py): replace \left( to \mathopen{}\left( and \ri…
jianan1104 8747b1c
fix(function_codegen.py): Fix brackets display
jianan1104 3f70423
refactor(function_codegen.py): Remove '{}' for non-fstring
jianan1104 e13a283
fix(regression_test.py): Replace \left( to \mathopen{}\left( and \rig…
jianan1104 66cf5ee
fix(function_codegen_test.py): Replace \left( to \mathopen{}\left( an…
jianan1104 cbdfe33
fix(checks.sh): Fix typo [pflake -> flake8]
jianan1104 9f037ba
refactor: Using isort to sort imports alphabetically
jianan1104 7f1373b
refactor: Using black to reformat codes
jianan1104 8558f11
Merge pull request #1 from jianan1104/main
jianan1104 a2d1cd7
Revert "fix(checks.sh): Fix typo [pflake -> flake8]"
jianan1104 3dfefeb
Revert "refactor: Using isort to sort imports alphabetically"
jianan1104 cde8fa5
refactor(regression_test.py): Lint codes to fix E501 line too long
jianan1104 da4e42c
refactor(function_codegen_test.py): Lint codes to fix E501 line too long
jianan1104 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "refactor: Using isort to sort imports alphabetically"
This reverts commit 9f037ba.
commit 3dfefebe8779bea0771480e0b6a954ce47e875f6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
"""Package latexify.transformers.""" | ||
|
||
from latexify.transformers import assignment_reducer, identifier_replacer | ||
from latexify.transformers import assignment_reducer | ||
from latexify.transformers import identifier_replacer | ||
|
||
|
||
AssignmentReducer = assignment_reducer.AssignmentReducer | ||
IdentifierReplacer = identifier_replacer.IdentifierReplacer |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes about only the import order, which are not related to the essential point of this pull request. Could you revert these changes to prevent breaking the blame history?
(Btw, I think I need to introduce some static checker (e.g., isort) to constrain the style around imports.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done