Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show example in Readme #122

Merged
merged 1 commit into from
Nov 19, 2022
Merged

Show example in Readme #122

merged 1 commit into from
Nov 19, 2022

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Nov 19, 2022

Now when people visit this GitHub page, they'll immediately understand what this package does.

@cool-RR cool-RR requested a review from odashi as a code owner November 19, 2022 09:21
odashi
odashi reviewed Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is definitely useful for users.

Though this is just a matter of taste, I prefer PNG a bit over JPEG for screenshots. I'd also be happy to merge it as-is if there's some intent to choose the current format.

@cool-RR cool-RR force-pushed the main branch 3 times, most recently from 74868f1 to 2d54c4b Compare November 19, 2022 09:41
@cool-RR
Copy link
Contributor Author

cool-RR commented Nov 19, 2022

I tried converting it to png now, but I got some weird transperancy issues. I tried both Irfanview and Photoshop and got the same weird result. So I'd prefer that you merge it with jpg.

odashi
odashi approved these changes Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, sure I'd merge it as-is.

@odashi odashi merged commit f57dcda into google:main Nov 19, 2022
@odashi odashi added the documentation Improvements or additions to documentation label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odashi odashi odashi approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cool-RR @odashi