Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README.md): add nice badges to README #128

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

jianan1104
Copy link
Contributor

Overview

add nice badges to README

Details

image

@jianan1104 jianan1104 requested a review from odashi as a code owner November 21, 2022 04:14
@odashi
Copy link
Collaborator

odashi commented Nov 21, 2022

I'm a bit thinking if it's better that the badges are placed on the header (before the title) or not. WDYT

無題

@jianan1104
Copy link
Contributor Author

jianan1104 commented Nov 21, 2022

I'm a bit thinking if it's better that the badges are placed on the header (before the title) or not. WDYT

無題

@odashi
I think it's okay for any style. most github repos are let badges under the title. btw, I think we need a pretty avatar or cover
image

@odashi
Copy link
Collaborator

odashi commented Nov 21, 2022

Great, I have no strong opinions and it'd be okay to go with the most common way.

Co-authored-by: Yusuke Oda <yusuke.oda@predicate.jp>
@jianan1104
Copy link
Contributor Author

Great, I have no strong opinions and it'd be okay to go with the most common way.

Sure, let's do it.

@odashi odashi merged commit 7adf568 into google:main Nov 22, 2022
@odashi odashi added the documentation Improvements or additions to documentation label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants