Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyword to all AST node constructor positional arguments. #131

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Add keyword to all AST node constructor positional arguments. #131

merged 2 commits into from
Nov 21, 2022

Conversation

ZibingZhang
Copy link
Contributor

@ZibingZhang ZibingZhang commented Nov 21, 2022 •
edited
Loading

Overview

Adds keywords to AST node constructor positional arguments.

References

#125 (review)

@ZibingZhang ZibingZhang requested a review from odashi as a code owner November 21, 2022 17:19
odashi
odashi approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch-up, thanks!

@odashi odashi merged commit c088553 into google:main Nov 21, 2022
@ZibingZhang ZibingZhang deleted the keyword-all-ast-args branch November 22, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odashi odashi odashi approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZibingZhang @odashi