Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix trimming as a node transformer #137

Closed
wants to merge 5 commits into from
Closed

Prefix trimming as a node transformer #137

wants to merge 5 commits into from

Conversation

ZibingZhang
Copy link
Contributor

@ZibingZhang ZibingZhang commented Nov 27, 2022 •
edited
Loading

Overview

Creates a node transformer to trim prefix names.

Details

Limitations:

  • unable to trim complex prefixes, e.g. a.b.c -> c

References

package name trimming as node transformer: #81
custom list of prefixes: #87

simplifies this closed PR: #113

@ZibingZhang ZibingZhang marked this pull request as ready for review November 27, 2022 12:21
@ZibingZhang ZibingZhang requested a review from odashi as a code owner November 27, 2022 12:21
@odashi
Copy link
Collaborator

odashi commented Nov 27, 2022

@ZibingZhang Thanks, but I'm just working for this with more complete approaches:
https://github.com/google/latexify_py/tree/81-prefix-trimmer

If it would be okay please close this pull request.

@ZibingZhang
Copy link
Contributor Author

no worries will do :)

@ZibingZhang ZibingZhang deleted the prefix-trimmer branch November 27, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odashi odashi Awaiting requested review from odashi odashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZibingZhang @odashi