Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues from factoring out expression codegen #159

Merged
merged 5 commits into from
Dec 10, 2022

Conversation

ZibingZhang
Copy link
Contributor

Overview

#148 was merged in after #155 had been opened, and at some point when resolving merge conflicts (?) the changes have been lost.

This PR adds them back in.

References

Lost changes: #148
PR with that accidentally deleted them: #155

Blocked by

None

@ZibingZhang ZibingZhang requested a review from odashi as a code owner December 10, 2022 07:29
@odashi
Copy link
Collaborator

odashi commented Dec 10, 2022

Thanks for the quick fix!

@odashi odashi merged commit c4c98ba into google:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants