Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend refactor -- ipython_wrapper for decorator output, setup work for ipython-algorithmic codegen #164

Merged
merged 31 commits into from
Dec 13, 2022
Merged

Frontend refactor -- ipython_wrapper for decorator output, setup work for ipython-algorithmic codegen #164

merged 31 commits into from
Dec 13, 2022

Conversation

ZibingZhang
Copy link
Contributor

@ZibingZhang ZibingZhang commented Dec 11, 2022 •
edited
Loading

Overview

Refactor frontend.

Details

  • extract LatexifiedFunction into ipython_wrapper also with a new class LatexifiedAlgorithm (with common base class LatexifiedRepr
  • New style IPYTHON_ALGORITHMIC along with new frontend decorator @algorithmic

References

The first half of this PR: #163

Blocking

Blocking the testing of IPythonAlgCodegen (#163), which is why I've extracted this portion out first.

Blocked by

None

@ZibingZhang ZibingZhang requested a review from odashi as a code owner December 11, 2022 13:26
@odashi
Copy link
Collaborator

odashi commented Dec 11, 2022

Title: it is somewhat hard to understand what "FE" is, and it denies to find this PR from the keyword search.

@ZibingZhang ZibingZhang changed the title Revise FE to support multiple env targets Revise frontend to support multiple environment targets Dec 11, 2022
@ZibingZhang ZibingZhang mentioned this pull request Dec 11, 2022
Merged
odashi
odashi reviewed Dec 11, 2022
View reviewed changes
Zibing Zhang added 2 commits December 11, 2022 23:14
@ZibingZhang ZibingZhang requested a review from odashi December 11, 2022 23:24
@odashi
Copy link
Collaborator

odashi commented Dec 12, 2022

Since I'm working on the company and have limited time to work on this repository, could you re-request reviews after finishing all modifications?
I could notice new comments without re-requesting review btw.

@ZibingZhang ZibingZhang changed the title Revise frontend to support multiple environment targets Frontend refactor -- separate LatexifiedFunction out Dec 12, 2022
odashi
odashi reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change involves ipython_wrappers too, but the title doesn't point to this and there's no blocker in the description.

@ZibingZhang ZibingZhang changed the title Frontend refactor -- separate LatexifiedFunction out Frontend refactor -- ipython_wrapper for decorator output, setup work for ipython-algorithmic codegen Dec 12, 2022
@ZibingZhang
Copy link
Contributor Author

there's no blocker in the description

Not sure what you mean by this. I don't think these changes are blocked by anything

@odashi
Copy link
Collaborator

odashi commented Dec 12, 2022

I meant that if this change intended to introduce only separating get_latex, it is weird that there is no blocked_by items in the description.

odashi
odashi reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only trivial fixes

@ZibingZhang ZibingZhang requested a review from odashi December 13, 2022 13:19
odashi
odashi reviewed Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is the last

ZibingZhang and others added 5 commits December 13, 2022 14:11
@ZibingZhang @odashi
Update src/latexify/ipython_wrappers.py
97b80d0 
Co-authored-by: Yusuke Oda <yusuke.oda@predicate.jp>
@ZibingZhang @odashi
Update src/latexify/ipython_wrappers.py
4ea62d6 
Co-authored-by: Yusuke Oda <yusuke.oda@predicate.jp>
@ZibingZhang @odashi
Update src/latexify/ipython_wrappers.py
0797841 
Co-authored-by: Yusuke Oda <yusuke.oda@predicate.jp>
@ZibingZhang @odashi
Update src/latexify/ipython_wrappers.py
0f8394a 
Co-authored-by: Yusuke Oda <yusuke.oda@predicate.jp>
import cast
c86a531
@odashi
Copy link
Collaborator

odashi commented Dec 13, 2022

Hey @ZibingZhang , I noticed that you are committing with at least 2 different accounts. In most cases this means that your local environment does not set the account information correctly. Please check how you set git config on your machine.

@ZibingZhang
Copy link
Contributor Author

Hey @ZibingZhang , I noticed that you are committing with at least 2 different accounts. In most cases this means that your local environment does not set the account information correctly. Please check how you set git config on your machine.

Just checked and yup my email address wasn't the same as my GitHub account, thanks for letting me know! I've just fixed it, and it shouldn't be a problem for future commits / PRs.

@odashi odashi merged commit 144073b into google:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odashi odashi odashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZibingZhang @odashi