Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the library #58

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Refactoring of the library #58

merged 3 commits into from
Oct 21, 2022

Conversation

odashi
Copy link
Collaborator

@odashi odashi commented Oct 21, 2022 •
edited
Loading

This change introduces several refactoring:

  • Give more consistent argument names. (breaking change)
  • Separate core.py into several modules:
    • math_symbols.py for math symbol manipulation.
    • latexify_visitor.py for the core NodeVisitor.
    • frontend.py for frontend interfaces.
  • And many other cherrypicks.

@odashi odashi requested a review from ShigekiKarita October 21, 2022 09:05
ShigekiKarita
ShigekiKarita reviewed Oct 21, 2022
View reviewed changes
src/latexify/math_symbols.py
"Gamma",
"Lambda",
"Omega",
"Phi",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add \Psi?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch up, thanks!

ShigekiKarita
ShigekiKarita approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@ShigekiKarita ShigekiKarita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see well-typed and smaller modules.

@odashi odashi merged commit 1421ddb into main Oct 21, 2022
@odashi odashi deleted the refactoring branch October 21, 2022 09:27
@odashi odashi added the feature label Oct 24, 2022
@odashi odashi added this to the v0.2 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShigekiKarita ShigekiKarita ShigekiKarita approved these changes

Assignees
No one assigned
Labels
feature refactoring
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@odashi @ShigekiKarita