Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve visit_BoolOp implementation #62

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Improve visit_BoolOp implementation #62

merged 5 commits into from
Oct 24, 2022

Conversation

odashi
Copy link
Collaborator

@odashi odashi commented Oct 23, 2022

Overview

Implements following changes for BoolOp manipulation:

  • Change the generated syntax to {x op x op ... op x}
  • Support multiple operands.

Details

This change implements a similar strategy in visit_Comare in #61. Since BoolOp takes the same operator for every operand, visit_BoolOp looks relatively simpler than visit_Compare.

References

Blocked by

@odashi odashi requested a review from ShigekiKarita October 23, 2022 08:14
ShigekiKarita
ShigekiKarita approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@ShigekiKarita ShigekiKarita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement

@odashi odashi added this to the v0.2 milestone Oct 24, 2022
@odashi odashi added the feature label Oct 24, 2022
@odashi odashi merged commit 4ff77b4 into main Oct 24, 2022
@odashi odashi deleted the bool-ops branch October 24, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShigekiKarita ShigekiKarita ShigekiKarita approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@odashi @ShigekiKarita