Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove action enum, and add Latexify specific exceptions #68

Merged
merged 5 commits into from
Oct 30, 2022

Conversation

odashi
Copy link
Collaborator

@odashi odashi commented Oct 29, 2022

Overview

Introduces following changes:

  • Removes Actions enum and replace them to a raw string.
  • Introduces LatexifyError and some subclasses.
  • Introduces a behavior when LatexifiedFunction met some LatexifyErrors.

Details

Actions is eventually used as an identical stuff with strings. Maintaining this struct is no longer necessary as some other actions in LatexifyVisitor are defined as raw strings.

LatexifyError indicates internal errors of Latexify itself that can't be recovered by users.
with_latexify now captures this error to prevent destroying the runtime. Jupyter works as follows:

References

NA

Blocked by

NA

@odashi odashi added this to the v0.2 milestone Oct 29, 2022
@odashi odashi requested a review from ShigekiKarita October 29, 2022 18:35
Copy link
Collaborator

@ShigekiKarita ShigekiKarita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Shigeki Karita <6745326+ShigekiKarita@users.noreply.github.com>
@odashi odashi merged commit af68c09 into main Oct 30, 2022
@odashi odashi deleted the add-exception-classes branch October 30, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants