Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More refactoring #71

Merged
merged 8 commits into from
Oct 31, 2022
Merged

More refactoring #71

merged 8 commits into from
Oct 31, 2022

Conversation

odashi
Copy link
Collaborator

@odashi odashi commented Oct 31, 2022 •
edited
Loading

Overview

  • Support all constant literals.
  • Digits are wrapped by { and } so that the subscript operator works: $x_42$ --> $x_{42}$
    • This would insert unnecessarily many braces at this point, need further refactoring.
  • Separate parsing strategy from get_latex to parser.parse_function.
  • Test utilities:
    • Make ast_equal stricter.
    • Add require_at_least/most decorator to run tests on only specific Python verisons.
  • Other trivial refactoring.

Details

NA

References

NA

Blocked by

NA

@odashi odashi added this to the v0.2 milestone Oct 31, 2022
@odashi odashi requested a review from ShigekiKarita October 31, 2022 03:46
ShigekiKarita
ShigekiKarita approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@ShigekiKarita ShigekiKarita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odashi odashi merged commit 1902950 into main Oct 31, 2022
@odashi odashi deleted the refactoring branch October 31, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShigekiKarita ShigekiKarita ShigekiKarita approved these changes

Assignees
No one assigned
Labels
feature refactoring
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@odashi @ShigekiKarita