Keep C++ standard flexible #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
WDYT about CI failures? |
|
@vitalybuka Sorry, I'll check tomorrow. Thank you for pinging :) |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
@vitalybuka I updated the c++ standard to use C++14 for Protobuf. |
vitalybuka
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We are packaging libprotobuf-mutator in ConanCenterIndex (PR conan-io/conan-center-index#24163) and I noted that the required C++ standard is enforced to C++14 only, making not possible to use C++17 or newer.
In this PR I added target_compile_features to keep C++14 as minimal standard required, so people can use newer C++ standards too.
The examples and tests are consuming
protobuf-mutator, so they will receive the same C++ standard flag because is marked as public.