Extract most of LLVMFuzzerCustomMutator and LLVMFuzzerTestOneInput into fuzzing_helpers.h #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikea
reviewed
Jan 12, 2017
| @@ -0,0 +1,24 @@ | |||
| language: cpp | |||
| output->Clear(); | ||
| TextFormat::Parser parser; | ||
| parser.AllowPartialMessage(true); | ||
| parser.ParseFromString({data, data + size}, output); |
There was a problem hiding this comment.
what if it fails? Warning or something is helpful.
There was a problem hiding this comment.
I'd expect that common practice will be use of copruses generated by other tools.
In this case incompatible are expected.
I believe this warning will likely be a noise than actionable thing.
| @@ -15,47 +15,23 @@ | |||
| #include <cstddef> | |||
| #include <cstdint> | |||
|
|
|||
| #include "google/protobuf/text_format.h" | |||
| #include "fuzzing_helpers.h" | |||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #ifndef FUZZING_HELPERS_H_ |
There was a problem hiding this comment.
Let's add these 2 functions as high-level api to protobuf_mutator.h and .cc files. We won't need helpers then.
vitalybuka
force-pushed
the
master
branch
28 times, most recently
from
25a3693 to
71a4836
Compare
vitalybuka
force-pushed
the
master
branch
20 times, most recently
from
8c1ed44 to
2b1372d
Compare
mikea
approved these changes
Jan 13, 2017
This was referenced Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.