This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix the terminfo detection to work without a CC env variable.
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought the `which` API would be well behaved here, but it produces a hard error on a `None` argument. Using a default of `""` doesn't work either because of bazelbuild/bazel#12216
GMNGeoffrey
approved these changes
Oct 3, 2020
Comment on lines
+50
to
+51
| if cc_env: | ||
| cc = repository_ctx.which(cc_env) |
There was a problem hiding this comment.
Just a note that this will also skip if CC="". I think that's what we want, but something to bear in mind. The python style guide says to always make None comparisons explicit for that reason https://google.github.io/styleguide/pyguide.html#2144-decision
There was a problem hiding this comment.
Yeah, we actually want that for now due to the Bazel bug. And even when fixed, there is no point, do this still seems good to avoid a pointless call to which.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought the
whichAPI would be well behaved here, but it producesa hard error on a
Noneargument. Using a default of""doesn't workeither because of bazelbuild/bazel#12216