Exit with non-zero code if at least one error was encountered (#784)

Fixes #780

rust/cli/CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Minor
 
+- Exit with non-zero code if at least one error was encountered (fixes #780)
 - Print model version with `--version`
 - Change model from `standard_v2_0` to `standard_v2_1`
 

rust/cli/src/main.rs

@@ -199,9 +199,11 @@ async fn main() -> Result<()> {
         print!("[");
     }
     let mut reorder = Reorder::default();
+    let mut errors = false;
     while let Some(response) = result_receiver.recv().await {
         reorder.push(response?);
         while let Some(response) = reorder.pop() {
+            errors |= response.result.is_err();
             if flags.format.json {
                 if reorder.next != 1 {
                     print!(",");
@@ -221,6 +223,9 @@ async fn main() -> Result<()> {
         }
         println!("]");
     }
+    if errors {
+        std::process::exit(1);
+    }
     Ok(())
 }
 

rust/cli/test.sh

@@ -34,3 +34,20 @@ info "Test against the test suites: $TEST_SUITES"
     [ "$expected" = "$actual" ] || error "$file is detected as $actual"
   done
 )
+
+info "Test exit code with at least one error"
+test_error() {
+  files="$1"
+  expected="$2"
+  ( set +e
+    actual="$(magika $files)"
+    code=$?
+    [ $code -eq 1 ] || error "invalid exit code for magika $files"
+    [ "$actual" = "$expected" ] || error "invalid output for magika $files"
+  )
+}
+test_error '/etc/shadow' "\
+/etc/shadow: Permission denied (os error 13) (error)"
+test_error 'non_existent src/main.rs' "\
+non_existent: No such file or directory (os error 2) (error)
+src/main.rs: Rust source (code)"