Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic in ModifyResponse by setting request back after roundtrip #308

Merged
merged 1 commit into from
Jan 9, 2020
Merged

fix panic in ModifyResponse by setting request back after roundtrip #308

merged 1 commit into from
Jan 9, 2020

Conversation

zema1
Copy link
Contributor

@zema1 zema1 commented Jan 8, 2020

No description provided.

@zema1 zema1 mentioned this pull request Jan 8, 2020
Open
admtnnr
admtnnr approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@admtnnr admtnnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and makes sense to me why/how it fixes the panic you were experiencing. Sorry you ran into that!

@bramhaghosh bramhaghosh merged commit 5f8cb63 into google:master Jan 9, 2020
@zema1 zema1 deleted the panic-fix branch January 12, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admtnnr admtnnr admtnnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zema1 @admtnnr @bramhaghosh