Implement Checkbox v2 Component #4471
Comments
This was referenced Jul 1, 2016
|
There's a small accessibility bug with the current checkbox. Screenreaders (ChromeVox, at least) use the underlying checkbox input for highlighting. The original input is offset somewhat from the upgraded version. Here's a screenshot. Could you keep this in mind with the v2 component? Thanks!
|
|
Yup, Travis is working on this honking component currently. Once it is up for review I'll be running it through Chromevox and NVDA to test. This is great feedback to keep an eye on. Thank you. |
traviskaufman
added a commit
that referenced
this issue
Aug 5, 2016
This commit converts the checkbox POC code over to the new architecture, adds unit tests, and ports the demos over to working implementations. It also adds a README, and modifies .stylelintrc.yaml to increase the number of compound selectors we can use. Note that ink ripple functionality will be covered in a separate issue. Finishes #4471 [Delivers #126819487]
traviskaufman
added a commit
that referenced
this issue
Aug 5, 2016
This commit converts the checkbox POC code over to the new architecture, adds unit tests, and ports the demos over to working implementations. It also adds a README, and modifies .stylelintrc.yaml to increase the number of compound selectors we can use. Note that ink ripple functionality will be covered in a separate issue. Finishes #4471 [Delivers #126819487]
traviskaufman
added a commit
that referenced
this issue
Aug 8, 2016
This commit converts the checkbox POC code over to the new architecture, adds unit tests, and ports the demos over to working implementations. It also adds a README, and modifies .stylelintrc.yaml to increase the number of compound selectors we can use. Note that ink ripple functionality will be covered in a separate issue. Finishes #4471 [Delivers #126819487]
traviskaufman
added a commit
that referenced
this issue
Aug 8, 2016
This commit converts the checkbox POC code over to the new architecture, adds unit tests, and ports the demos over to working implementations. It also adds a README, and modifies .stylelintrc.yaml to increase the number of compound selectors we can use. Note that ink ripple functionality will be covered in a separate issue. Finishes #4471 [Delivers #126819487]
traviskaufman
added a commit
that referenced
this issue
Aug 8, 2016
This commit converts the checkbox POC code over to the new architecture, adds unit tests, and ports the demos over to working implementations. It also adds a README, and modifies .stylelintrc.yaml to increase the number of compound selectors we can use. Note that ink ripple functionality will be covered in a separate issue. Finishes #4471 [Delivers #126819487]
traviskaufman
added a commit
that referenced
this issue
Aug 8, 2016
* feat(animation): Clean up mdl-animation, add README * feat(checkbox): Add initial checkbox implementation This commit converts the checkbox POC code over to the new architecture, adds unit tests, and ports the demos over to working implementations. It also adds a README, and modifies .stylelintrc.yaml to increase the number of compound selectors we can use. Note that ink ripple functionality will be covered in a separate issue. Finishes #4471 [Delivers #126819487]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spec reference: https://www.google.com/design/spec/components/selection-controls.html#selection-controls-checkbox
The text was updated successfully, but these errors were encountered: