-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select Input #854
Comments
@Bamertos Select, is just standard HTML select elements. Right now we have no guidance on how selects should look, other than chip systems which is a planned addition and we could build off from that. We should get in touch with the MD team on how to proceed in the best way. On the note of simply needing more form components, please file specific issues and use-cases. The more actionable and specific items we have to work on the better. |
@Garbee What about this? It's look like a Select input |
Oh nice catch. It is placed under Menus... Ok, good enough for me. I'll bring it up when we start planning new component additions. One thing is, we could also want to support chips under selects for an advanced view for dropdowns (since they could be interchangeable specs for the task.) EDIT: And leaving guidance task just as a reminder to verify with the MD team that this is a valid use-case. Looks like it should be, but better safe than sorry when implementing. |
@Rom4eg Where did you find that example with the address input? I've been trying to figure out how to do a dropdown as well and that would work fine for me, but I cannot find the example that shows that interface and how to create it. |
@adammhaile That is from the Material Design specification. MDL has yet to implement that functionality. For now it will need to be a custom implementation. |
Ahhh... OK. That's unfortunate. Thanks for clarifying. I'll just have to On Thu, Jul 9, 2015 at 11:14 AM, Jonathan Garbee notifications@github.com
|
I thought it is bad to break the default select implement from the browser. If we must implement it, then we need to implement all types of layout of every browsers for the best accessibility. |
We can style desktop systems a bit and leave mobile to act as it normally would. |
Makes sense to me. Select is used a lot and it would be a shame to have it On Sat, Jul 11, 2015 at 10:10 AM, Jonathan Garbee notifications@github.com
|
@Garbee |
@mmis1000 Yes, it should be doable. What is the point behind the jsbin? |
just a small example for customized look select element |
that is an accepted bug, please stop adding "+1" to it. hit the subscribe button in the sidebar if you want to track progress. |
Hey guys, is anyone working on this? In the meantime I made my own "css only"-version (simple) http://codepen.io/pudgereyem/pen/PqBxQx/ Btw, it seems like Angular Material have implemented this already; https://material.angularjs.org/latest/#/demo/material.components.select |
i just clone Textfield js and css code into a new one and it works in chrome but not perfect. |
I've started work on adding this to MDL, should I make a pull request? |
@langan Awesome! I’d be happy to look over your pull request :) |
Ive pushed my code to a branch on my fork It's my first attempt at anything on this project so let me know if it looks ok and if its worth continuing (would be happy to work on it further and add an example component page) |
@langan Don’t be afraid to open up a proper PR. That we’ll have an isolated thread for discussion and review |
More examples can be found in Polymer and Angular-Material |
Hello ! +1 It would have been really usefull to have it. |
This is for my cloned repo. It uses gulp internally. For one project i'm working on, i created another special repo where i "cook" my own MDL build. That build includes datepicker, selectfield, some custom color definitions, etc. But this is esentially clone of original MDL repo using all MDL infrastructure. |
I'll come back with some feedback later this evening. Made a branch here: https://github.com/leifoolsen/mdl-ext/tree/evaluate/mdl-select |
Thanks for testing it.
|
You have duplicated the otions into a lot of divs. In my opinion it's no longer a select element - it's someting else. |
Yes, exactly. It is no longer select element - it is component that works on top of select element since each browser has it's own select element styling. |
@dgrubelic: I think this is more i line with what you are developing: WAI-ARIA Authoring Practices 1.1, Listbox. If I develop a component myself, I check with this website. Is there a component described here, I get a lot for free with regard to documentation and test cases. EDIT: ... or the Wai-Aria Combo Box. |
And what would be the point here? I actually don't understand you. Are you saying that i'm doing something wrong with this implementation? And if so, why is it wrong? How would you submit listbox values through form? As far as i can see, all examples i found online are using exactly select element to accomplish this task. The only difference between select element is TBH, I actually no longer find this discussion productive since i'm just getting info that i'm doing something wrong, but not a suggestion how to improve (or totally rewrite) current component state. That being said, I'll remain my focus on current implementation and see what MDL team has to say about my proposal. |
I have tried to be constructive in my feedback, but if your perception is different I respect tha. |
Bummer: There is no select CSS in MDL See: google/material-design-lite#854
+1 |
1 similar comment
+1 |
People, please, do not "+1".This is really not constructive comment as we already know how much this component is needed. Actually, i have no idea on which part do you focus with your "+1". Is it topic and component itself, or some comment... Also, you can subscribe to this topic, if that is why you're commenting... |
Guys, I just want to point out that it is very hard to take MDL as a serious choice for material design based UI toolkit if it does not even provide select/dropdownlist component. Using a standard HTML select within an MDL screen makes the UI look inconsistent/ugly. Hope you will consider prioritising this for next major version. If not a full-fledge select component, at least an interim solution/guidance...maybe adopting/adapting some of the good work from the guys on this issue. Thanks! If you agree, please 👍 this post to help bump its priority. |
I have no idea how this issue can be open for almost a whole year and there is still no solution. Is this still in active development, apart from the external pull requests? The last commit in any branch seems to be over 1 month old. Without a select component, this is really not working out for anybody really. |
... and please, no JS generated elements! It'a a pain to style such stuff; a designer shuld have 100% control of markup. Don't make the Java Server Faces mistakes all over again. |
There are quite a few issues with modifying the styling here. It is a non-trivial issue and finding the best path forward requires a lot of testing and prototype code to churn though. It takes time and everyone has other tasks to work on as well. Select inputs are a form component, which is extremely high priority for web sites. However, due to it being a form component that means much more care needs to be taken in modifying/replacing it. Whatever we do needs to be fully accessible and align as closely as we can to the MD spec. Restyling native elements are notoriously difficult and also near impossible to align to MD with just that. So replacing the elements somehow is required (which means JS generated elements.) However, they must built with accessibility in mind which increases the difficulty. And how we handle this on mobile is also undecided. On mobile, we can either provide the custom design which isn't very accessible for people with vision impairments. So most likely we would want to fall back to the native select UX on mobile devices, which makes things more difficult to get just right. This problem is far from trivial and will require quite a few days of work from whomever puts forward this work if they do it before I get to it (which I'm planning on after we finalize how we want 2.x components to look.) But, it needs to be fully accessible and align to MD standards which is problematic, especially when the spec currently isn't built for web/desktop usage. |
@GabrielGil. To style a select box, as you mention, is no trivial task - especially if one wishes to preserve the semantics. The simplest is perhaps to give it a light MDL overhaul, so that when it acts as a dropdown list it is consistent with MDL text fields. If anyone wants more advanced list boxes, one can create a component for this, but not based on a select element that has limited styling capabilities. |
If we do a simple version that doesn't align we are only going to get repeated complaints that we aren't aligning. 😦 There isn't a way to win here except to put forth the full effort initially to completely align (except where we absolutely shouldn't) and be accessible. |
@kctang @devboxr If you just need a simple dropdown select element, you can just pull code from my github: https://github.com/leifoolsen/mdl-ext/tree/master/src/selectfield Some alternatives: |
Superseded by #4475. |
Did anyone implemented an input select using mdl? |
Hello all, I was searching for a component that fulfills all my needs, but I never found that, so I decided to create my own Jquery plugin for this purpose. It has a filter functionality, and supports multiselect, as well as some other minor stuff. If you still looking for something like this, check it out, and let me know how it worked out for you! :) Find all here: Good luck! |
I made a great mistake using mdl template , Now i have to start over with using a new material template |
Hello
I just begin with Material design lite, and it's awesome. But i miss something et i didn't find it in the documentation.
I'm working on a form, and i didn't find a way to have good select input. (I find text/number input, checkbox, radio button, ...)
Someone can help me?
Thank you
Thomas
The text was updated successfully, but these errors were encountered: