Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated browser support for dropping IE8 #365

Merged
merged 2 commits into from
Jun 15, 2015
Merged

Conversation

Garbee
Copy link
Collaborator

@Garbee Garbee commented Jun 8, 2015

No description provided.

@addyosmani
Copy link
Contributor

I think we need to revise this table to factor in that Templates are IE10+ and components are IE9+. We could introduce a second table for achieving this or opt for a different way to visualise our support.

Thoughts?

@Garbee
Copy link
Collaborator Author

Garbee commented Jun 9, 2015

Or we could go with plain text. Templates use the layout which is JavaScript based, so that should be an understood thing at that point. I wouldn't worry about calling templates out until we hear enough clamoring that it isn't "clear".

Material Design Lite supports IE10+ and evergreen browsers. We provide a CSS-only experience for IE9.

@addyosmani
Copy link
Contributor

@marcacohen what are your thoughts on us going terse (e.g @Garbee's suggestion above) vs being more explicit about browser support? Do you have a preference?

@mco-gh
Copy link
Contributor

mco-gh commented Jun 10, 2015

Personally, I like a table because it gets the message across more visually and more viscerally than a sentence. Also, a row of green A's gives a stronger impression that we're covering a lot of ground. Could we go with a hybrid: use the table but add an asterisk for the special case cells?

@addyosmani
Copy link
Contributor

Could we go with a hybrid: use the table but add an asterisk for the special case cells?

This would get my vote.

@Garbee
Copy link
Collaborator Author

Garbee commented Jun 10, 2015

If the asterisk for special cases is wanted, then what is the difference from the existing setup in the PR keeping the A/B grading?

@mco-gh
Copy link
Contributor

mco-gh commented Jun 10, 2015

Your A and B grades capture most of the story, but not, for example, the fact that templates can't be used on IE9, even with fallback to CSS (if I'm understanding Addy's comment correctly). So my thought was the table conveys the high level assessment and an asterisk could be used for any finer grain details, like the template constraint.

@Garbee
Copy link
Collaborator Author

Garbee commented Jun 10, 2015

I think the templates are more related to layout requiring JS, which should be addressed in the docs for Layout directly.

Templates are just example structures we provide as examples of what can be done, they shouldn't be copied directly and expected to work everywhere. They follow the same support rules as the rest of the project.

@mco-gh
Copy link
Contributor

mco-gh commented Jun 10, 2015

Sounds reasonable. Maybe we can get away with a short note to that effect below the table?

@Garbee
Copy link
Collaborator Author

Garbee commented Jun 10, 2015

Hmm, looking over the full readme again, noting browser support on Templates should be done under the template section (just above browser support). That way it is more direct to the topic at hand there.

Also, support should be moved above the template section, developers will probably want that information sooner than example templates.

@Garbee
Copy link
Collaborator Author

Garbee commented Jun 11, 2015

Updated to tackle the note, probably a bit strong though.

@Garbee Garbee force-pushed the browser-support-update branch from 1893faa to 6f3f7b3 Compare June 15, 2015 11:32
@Garbee
Copy link
Collaborator Author

Garbee commented Jun 15, 2015

Quote updated per @addyosmani's suggestion. Much better linking off to the test so people know exactly what should be supported.

@mco-gh
Copy link
Contributor

mco-gh commented Jun 15, 2015

LGTM

Garbee added a commit that referenced this pull request Jun 15, 2015
Updated browser support for dropping IE8
@Garbee Garbee merged commit 9dd6177 into master Jun 15, 2015
@Garbee Garbee deleted the browser-support-update branch June 15, 2015 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants