Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making shadow declarations consistent between elevations 0 and 24. #4123

Merged
merged 1 commit into from
Feb 17, 2016

Conversation

sgomes
Copy link
Contributor

@sgomes sgomes commented Feb 15, 2016

Also adds missing elevations.

@Garbee or @surma: PTAL!

@Garbee
Copy link
Collaborator

Garbee commented Feb 15, 2016

Where are these missing elevations specified for use/construction? I don't recall ever seeing where they are necessary somehow. We shouldn't include extra things like this without a clear use-case imo. It isn't keeping things lite.

Also, 0dp... Isn't that just box-shadow:none;? Where does adding this one in particular provide benefit?

@sgomes
Copy link
Contributor Author

sgomes commented Feb 16, 2016

We're adding the different elevations due to guidance from the MD team. Apparently, they should all be available, even though only a few examples are shown on the spec. They provided an algorithm to calculate the intermediate elevation values, as well as the full output of running that algorithm, which I used to create all the mixins.

You're right about the 0dp elevation; the numbers there were to make the calculation easier, but implementation-wise it makes more sense to have it as none. Made that change.

@Garbee
Copy link
Collaborator

Garbee commented Feb 16, 2016

AH ok, thanks for explaining why they are needed.

LGTM.

@sgomes
Copy link
Contributor Author

sgomes commented Feb 17, 2016

Thanks, @Garbee!

sgomes added a commit that referenced this pull request Feb 17, 2016
Making shadow declarations consistent between elevations 0 and 24.
@sgomes sgomes merged commit 7f71e5f into master Feb 17, 2016
@sgomes sgomes deleted the moar-shadows branch February 17, 2016 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants