Removing requestAnimationFrame polyfill now we've dropped IE9. #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One sec, investigating build breakage. |
|
Looks like node doesn't support |
|
Good to review now :) |
| @@ -86,7 +86,7 @@ function init() { | |||
| mc.template = this.responseText; | |||
| mc.highlightField('Indigo'); | |||
| mc.highlightField('Pink'); | |||
| window.requestAnimationFrame(function() { | |||
There was a problem hiding this comment.
It's still a function from window, no reason to remove that ;)
There was a problem hiding this comment.
That's true, this was a bit of an offtopic cleanup :)
|
LGTM +1 on dropping the window call. It isn't providing any benefit. |
|
It helps to know where it comes from :) And also prevent having an exception in file linting |
|
Thanks, @Garbee! |
sgomes
added a commit
that referenced
this pull request
Feb 17, 2016
Removing requestAnimationFrame polyfill now we've dropped IE9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@surma or @Garbee: PTAL!