chore(infrastructure): Add validate-commit-msg hook #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "commit-msg": "validate-commit-msg" | ||
| }, | ||
| "validate-commit-msg": { | ||
| "helpMessage": "Invalid commit message %s. Please see https://github.com/conventional-changelog/conventional-changelog/blob/v0.5.3/conventions/angular.md for information on how to format commit messages. Also, if this commit is on a development / WIP branch, you can disable this by running `git commit --no-verify`." |
There was a problem hiding this comment.
LGTM, though I would suggest adding a minimal sample to the error message.
It might make it too long, though... Can we have newlines?
There was a problem hiding this comment.
Also, is there a description somewhere of what each of the types means? Can't find it on the link.
There was a problem hiding this comment.
I would suggest adding a minimal sample
Great idea, will add. I don't really mind the length as it probably won't be changed that often.
is there a description somewhere of what each of the types means?
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#type
|
LGTM, thanks @traviskaufman! |
traviskaufman
force-pushed
the
chore/validate-commit-msg
branch
from
05d3128
to
b694c41
Compare
* Auto-installs a `commit-msg` hook when `npm (i|install)` is run. * Ensures that the commit message is formatted properly according to angular's conventions. Note that as outlined in the `helpMsg` key, this can always be disabled by passing the `--no-verify` option to `git-commit`. Part of #4464
traviskaufman
force-pushed
the
chore/validate-commit-msg
branch
from
b694c41
to
0c2c556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-msghook whennpm (i|install)is run.angular's conventions.
Note that as outlined in the
helpMessagekey, this can always be disabledby passing the
--no-verifyoption togit-commit.Part of #4464