Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons use only before psuedo #4628

Merged
merged 1 commit into from
Aug 4, 2016
Merged

Buttons use only before psuedo #4628

merged 1 commit into from
Aug 4, 2016

Conversation

Garbee
Copy link
Collaborator

@Garbee Garbee commented Aug 2, 2016

Make buttons use only the before pseudo. This allows tooltips to have after to themselves for them to inter-operate.

}

&:active::after {
&:active::before {
opacity: .06;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually decreases the opacity, when what we really want is to increase it. I think you mean .18 here (.12 + another .06)

@traviskaufman traviskaufman removed the PTAL label Aug 2, 2016
@traviskaufman
Copy link
Contributor

💎 LGTM besides that one comment.

@sgomes
Copy link
Contributor

sgomes commented Aug 4, 2016

LGTM other than @traviskaufman's comment.

@Garbee
Copy link
Collaborator Author

Garbee commented Aug 4, 2016

Fixed the opacity issue.

@Garbee
Copy link
Collaborator Author

Garbee commented Aug 4, 2016

Once CI passes since everything else is un-changed I'll go ahead and merge.

Let Tooltips have control over the after psuedo element so they will inter-operate with buttons.
@Garbee
Copy link
Collaborator Author

Garbee commented Aug 4, 2016

So, PTAL again just to verify I'm not insane. I saw we had a duplicate selector fixing the linting issue so I compressed it. Shouldn't cause any problems but.... this is CSS.

@Garbee Garbee added the PTAL label Aug 4, 2016
@traviskaufman
Copy link
Contributor

💎 You are, indeed, not insane :) LGTM!

@traviskaufman traviskaufman removed the PTAL label Aug 4, 2016
@traviskaufman traviskaufman merged commit 009d148 into master Aug 4, 2016
@traviskaufman traviskaufman deleted the hotfix/buttons branch August 4, 2016 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants