-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form-field): Initial Implementation #4815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise LGTM.
<input type="checkbox" | ||
id="my-checkbox" | ||
class="mdl-checkbox__native-control" | ||
aria-labelledby="my-checkbox-label"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably redundant.
<input type="checkbox" | ||
id="basic-checkbox" | ||
class="mdl-checkbox__native-control" | ||
aria-labelledby="basic-checkbox-label"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to this and all others
<input type="checkbox" | ||
id="checkbox-dark" | ||
class="mdl-checkbox__native-control" | ||
aria-labelledby="dark-checkbox-label"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably redundant.
|
||
### Usage with MDL Components | ||
|
||
`mdl-form-field` we'll work not just with `input` elements, but with _any_ element as long as its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/we'll work/will work/
<input type="checkbox" | ||
id="my-checkbox" | ||
class="mdl-checkbox__native-control" | ||
aria-labelledby="my-checkbox-label"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably redundant.
* Add mdl-form-field package * Refactor existing input controls to use mdl-form-field Resolves #4475 [Delivers #130834979]
2f8c15b
to
731e624
Compare
False negatives from TravisCI for node v4. Flaky SauceLabs. Merging. |
Resolves #4475
[Delivers #130834979]