Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-field): Initial Implementation #4815

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Conversation

traviskaufman
Copy link
Contributor

  • Add mdl-form-field package
  • Refactor existing input controls to use mdl-form-field

Resolves #4475
[Delivers #130834979]

Copy link
Contributor

@sgomes sgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM.

<input type="checkbox"
id="my-checkbox"
class="mdl-checkbox__native-control"
aria-labelledby="my-checkbox-label"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably redundant.

<input type="checkbox"
id="basic-checkbox"
class="mdl-checkbox__native-control"
aria-labelledby="basic-checkbox-label"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to this and all others

<input type="checkbox"
id="checkbox-dark"
class="mdl-checkbox__native-control"
aria-labelledby="dark-checkbox-label"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably redundant.


### Usage with MDL Components

`mdl-form-field` we'll work not just with `input` elements, but with _any_ element as long as its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/we'll work/will work/

<input type="checkbox"
id="my-checkbox"
class="mdl-checkbox__native-control"
aria-labelledby="my-checkbox-label"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably redundant.

* Add mdl-form-field package
* Refactor existing input controls to use mdl-form-field

Resolves #4475
[Delivers #130834979]
@traviskaufman
Copy link
Contributor Author

False negatives from TravisCI for node v4. Flaky SauceLabs. Merging.

@traviskaufman traviskaufman merged commit 8851695 into master Oct 5, 2016
@traviskaufman traviskaufman deleted the feat/form-field branch October 5, 2016 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants