feat(base): Add initialization, DOM events wrapper to component API. #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds an `initialize` constructor hook that is called after the root element is attached, but before `getDefaultFoundation` is called. * Adds a simple way of adding / removing event listeners from a component's root node, without needing access to the root node itself. Needed for #4475 [#126819221]
sgomes
approved these changes
Nov 16, 2016
|
running these tests one more time and if they're still flaky I'm merging and submitting a PR to bump up our SauceLabs timeouts (yet again) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initializeconstructor hook that is called after the rootelement is attached, but before
getDefaultFoundationis called.component's root node, without needing access to the root node itself.
Needed for #4475
[#126819221]