Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deepseek r1 tool call example polyfill (template newly adds trailing <think>) #52

Merged
merged 6 commits into from
Feb 9, 2025
Merged

Fix deepseek r1 tool call example polyfill (template newly adds trailing <think>) #52

merged 6 commits into from
Feb 9, 2025

Conversation

ochafik
Copy link
Collaborator

@ochafik ochafik commented Feb 9, 2025 •
edited
Loading

Also:

  • add golden output tests for tool handling of common templates
  • align python & c++ test logics (fix c++ extra context, fix python globals redefinitions, remove tojson override)

ochafik added a commit to ochafik/llama.cpp that referenced this pull request Feb 9, 2025
@ochafik
sync: minja (google/minja#52)
e598e7a
@ochafik ochafik marked this pull request as ready for review February 9, 2025 16:48
@ochafik ochafik merged commit 7eb5202 into main Feb 9, 2025
11 checks passed
@ochafik ochafik deleted the fix-deepseek-r1-example branch February 9, 2025 17:02
@ochafik ochafik mentioned this pull request Feb 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ochafik