Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iridescence & anisotropy models to the test suite #4486

Closed
bhouston opened this issue Sep 29, 2023 · 3 comments
Closed

Add iridescence & anisotropy models to the test suite #4486

bhouston opened this issue Sep 29, 2023 · 3 comments

Comments

@bhouston
Copy link
Contributor

Description

@echadwick-artist has created a series of new models for anisotropy and iridescence testing. We should add them to the test suite. He describes them here:

I would like to add all of the models he lists to the model-viewer test suite so that we have proper coverage in these undercovered areas.

Live Demo

None.

Version

None.

Browser Affected

None.

OS

None.

AR

None.

@elalish
Copy link
Contributor

elalish commented Oct 2, 2023

Yes, in fact I bet there are more models too - we haven't been keeping up with sample model updates very well. Not sure when I'll have time, but I'd welcome anyone who wants to drop a PR adding them.

@bhouston
Copy link
Contributor Author

bhouston commented Oct 3, 2023

I've created a pull request here: #4493 for the anisotropy models.

@elalish
Copy link
Contributor

elalish commented Jan 11, 2024

I believe you already added all of these, thanks!

@elalish elalish closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants