Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public API .d.ts file #1831

Closed
wants to merge 1 commit into from
Closed

Add public API .d.ts file #1831

wants to merge 1 commit into from

Conversation

elalish
Copy link
Contributor

@elalish elalish commented Jan 15, 2021

Fixes #1502

It does generate the single file, however it is giant and includes much more than our public API. I'll consider this blocked on Swatinem/rollup-plugin-dts#133 unless a better way can be found.

@michaelkochhugobosscom
Copy link

any news about that ?

@elalish
Copy link
Contributor Author

elalish commented Jul 27, 2021

No; can you give some detail of your desired dev process and what you're hoping to do? Most of our users just put MV in as HTML; it'll be helpful to know what TS users are up to. Our unbundled library is also published on npm, so it should be possible to import the files from /lib instead of the bundle, since those all have .d.ts files associated. I'd still like to get a single d.ts file that only includes our public API, but I have yet to figure out a good way to do that.

@Ducki
Copy link

Ducki commented Sep 17, 2021

'[…] and what you're hoping to do'
Well, for a start: not getting never ending errors and compilation failures because Typescript doesn't understand what I'm importing and using.
Further: actually using Typescript with the API of the model-viewer (also without getting errors and failing to compile).

@elalish
Copy link
Contributor Author

elalish commented Aug 19, 2022

Closing in favor of #3718

@elalish elalish closed this Aug 19, 2022
@elalish elalish deleted the dts branch August 19, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include TypeScript type definitions on npm package
3 participants