updated gltf-sample-viewer goldens #2018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@elalish We have implemented two version of ACES tonemapping. Actually, we need to discuss in 3D Formats / 3D Commerce, which one should be used and/or is preferred. |
|
I updated the gltf-sample-viewer on our branch. Now the issues with the screenshots should be fixed. VC is still brighter than in the other renderers, but the other screenshots look good. https://github.com/ux3d/model-viewer/tree/addGltfSampleViewer |
|
Great, can you make a PR? I'll update this one after we merge yours. VC is weird; Filament had a bunch of trouble with it too. Something to do with how ambient occlusion is handled iirc. |
|
Closing in favor of #2128. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of the scrollbars.
@UX3D-haertl Looking at https://modelviewer.dev/fidelity/, it appears you still have a problem with tone-mapping or exposure. It's especially obvious on Cube, Duck, and the simple grey tests toward the bottom. Also the furnace test is wrong, as it doesn't have the proper grey background and the spheres look over-exposed. Would you mind fixing these issues before I merge this PR?