Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EXT_meshopt_compression #2706

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

donmccurdy
Copy link
Contributor

Fixes #1164.

Screen Shot 2021-08-22 at 8 01 55 PM

@google-cla
Copy link

google-cla bot commented Aug 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@donmccurdy
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Contributor

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Don!

- Add CC BY Attribution notice
- Consolidate files
- Styleguide fixes
@donmccurdy
Copy link
Contributor Author

Thanks @elalish – I think I've addressed the feedback. 👍🏻

Copy link
Contributor

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@elalish
Copy link
Contributor

elalish commented Aug 23, 2021

Looks like I checked in a flaky test to space-opera. I'm going to merge this, since the failure is definitely unrelated to anything here.

@elalish elalish merged commit 808bcd8 into google:master Aug 23, 2021
@donmccurdy donmccurdy deleted the feat-meshopt branch August 23, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "MESHOPT_compression" GLTF Extension
2 participants