Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model-viewer@v3 uses lottie-web as a dev dependency #4108

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

robertsLando
Copy link
Contributor

@robertsLando robertsLando commented Feb 8, 2023

This issue was caused because the lottie-web is listed as a dev dep to use it's types, in this case import statement is wrong as it would import all the module on runtime, using import type will fix the issue and used to check the types only on compilation stage

Fixes #4090

@google-cla
Copy link

google-cla bot commented Feb 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@robertsLando
Copy link
Contributor Author

robertsLando commented Feb 8, 2023

@elalish I have compiled the google cla, just re-run checks and should be ok

Copy link
Contributor

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you for finding the elegant fix!

@elalish elalish merged commit 5e9f5c6 into google:master Feb 10, 2023
@robertsLando
Copy link
Contributor Author

Thanks to you for this awesome module! 🙏🏻

JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model-viewer@v3 uses lottie-web as a dev dependency
2 participants