Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Khronos for taking over maintenance of our render fidelity comparisons! Now we can remove them from this repo, thus reducing our size considerably. This will mean that
git clone --depth=1
will be nice and fast now. Of course our history is still bloated with gigabytes of these golden images - I'm tempted to rewrite our history to remove them, but that's slightly more dangerous that I feel comfortable with at the moment.We're keeping the render-fidelity-tools package because we use it for render regression testing, particularly when we update three.js versions. But we've now removed all the other renderers, which also speeds our build process.
I also did a follow-on to #4543, to speed up
render-goldens
the same waynpm test
was speeded up: by keeping the browser page open and rendering each scenario inside.