Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expunge fidelity #4779

Merged
merged 5 commits into from
May 17, 2024
Merged

Expunge fidelity #4779

merged 5 commits into from
May 17, 2024

Conversation

elalish
Copy link
Collaborator

@elalish elalish commented May 17, 2024

Thanks to Khronos for taking over maintenance of our render fidelity comparisons! Now we can remove them from this repo, thus reducing our size considerably. This will mean that git clone --depth=1 will be nice and fast now. Of course our history is still bloated with gigabytes of these golden images - I'm tempted to rewrite our history to remove them, but that's slightly more dangerous that I feel comfortable with at the moment.

We're keeping the render-fidelity-tools package because we use it for render regression testing, particularly when we update three.js versions. But we've now removed all the other renderers, which also speeds our build process.

I also did a follow-on to #4543, to speed up render-goldens the same way npm test was speeded up: by keeping the browser page open and rendering each scenario inside.

@elalish elalish self-assigned this May 17, 2024
@elalish elalish merged commit b547092 into master May 17, 2024
5 checks passed
@elalish elalish deleted the expungeFidelity branch May 17, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant