Fixes code example #4851
Fixes code example #4851
Conversation
Fixed code example for pickMaterialExample to work in webXR
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -766,7 +766,7 @@ <h2 class="demo-title">Materials API</h2> | |||
| } | |||
| }; | |||
|
|
|||
| modelViewer.addEventListener("click", changeColor); | |||
| document.addEventListener("click", changeColor); | |||
There was a problem hiding this comment.
Have you tested this whole page? I'm guessing since there are multiple examples, this might have odd behavior. Maybe add a check in changeColor to ensure the event came through the right element?
There was a problem hiding this comment.
add a check in
changeColorto ensure the event came through the right element?
You are right. i think my new commit fixes this
Fixed code example for pickMaterialExample to work in webXR
About #4847