allow top and bottom view by default #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
commented
Oct 23, 2024
| @@ -627,7 +627,7 @@ | |||
| "htmlName": "minCameraOrbit", | |||
| "description": "Set the minimum orbital values of the camera. Note \"Infinity\" is not an accepted keyword, but the default can still be obtained by passing \"auto\". The radius value for \"auto\" is a conservative value to ensure the camera never enters the model, so be careful when setting this to another value.", | |||
| "default": { | |||
| "default": "-Infinity 22.5deg auto", | |||
There was a problem hiding this comment.
These are the legacy defaults, if anyone needs the old behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this updates our defaults, it is technically a breaking change, though very minor. Our default camera limits used to not allow a pure top or bottom view - they had to be manually extended to get the full 0-180 range of camera elevation. Now that is our default, but you can always set them back to how they were if you desire the legacy behavior.