Make Bazel build rules compatible with --incompatible_disallow_empty_glob
#1150
Assignees
Comments
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Dec 21, 2024
This follows up to my previous commit [1], which aimed to enable us to use Bazel to build executables with Qt6 dependencies. Thanks to '--incompatible_disallow_empty_glob', which is going to be enabled by default from Bazel 8.0, it is clear that an empty list was set to 'hdrs' despite my intention. Let's fix it (google#1150). There must be no change in the final artifacts. [1]: 019911b
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Dec 21, 2024
There was an attempt to make 'rules_android_ndk' compatible with '--incompatible_disallow_empty_glob' [1], but it seems that it was not complete. To unblock Mozc to enable '--incompatible_disallow_empty_glob' (google#1150), let's work around this in the Mozc side for now. There must be no behavior change in the final artifacts. [1]: bazelbuild/rules_android_ndk#37
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Dec 24, 2024
This follows up to my previous commit [1], which aimed to enable us to use Bazel to build executables with Qt6 dependencies. Thanks to '--incompatible_disallow_empty_glob', which is going to be enabled by default from Bazel 8.0, it is clear that an empty list was set to 'hdrs' despite my intention. Let's fix it (#1150). There must be no change in the final artifacts. [1]: 019911b PiperOrigin-RevId: 709014821
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Dec 24, 2024
There was an attempt to make 'rules_android_ndk' compatible with '--incompatible_disallow_empty_glob' [1], but it seems that it was not complete. To unblock Mozc to enable '--incompatible_disallow_empty_glob' (#1150), let's work around this in the Mozc side for now. There must be no behavior change in the final artifacts. [1]: bazelbuild/rules_android_ndk#37 PiperOrigin-RevId: 709015396
|
This should be now completed. |
yukawa
added a commit
to yukawa/mozc
that referenced
this issue
Feb 6, 2025
This follows up to my previous commit [1], which aimed to make 'rules_android_ndk' compatible with 'allow_empty_glob' (google#1150) with our own local patch. As rules_android_ndk 0.1.13 does include the fix [2], we no longer need to keep maintaining our local patch. [1]: 990c417 [2]: bazelbuild/rules_android_ndk#98
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Feb 10, 2025
This follows up to my previous commit [1], which aimed to make 'rules_android_ndk' compatible with 'allow_empty_glob' (#1150) with our own local patch. As rules_android_ndk 0.1.13 does include the fix [2], we no longer need to keep maintaining our local patch. [1]: 990c417 [2]: bazelbuild/rules_android_ndk#98 PiperOrigin-RevId: 725114927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Starting from Bazel 8.0,
--incompatible_disallow_empty_globis enabled by default.Let's make sure Mozc's build rules are compatible with it.
Steps to reproduce
--incompatible_disallow_empty_glob.Expected behavior
The build succeeds on all the supported platforms.
Version or commit-id
b7faa84
Additional Context
The text was updated successfully, but these errors were encountered: