Filter out wrong pronunciation of 般若心経 in the dictionary #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tats-u
changed the title
|
We have merged this PR. |
hiroyuki-komatsu
added a commit
that referenced
this pull request
Oct 10, 2024
2.30.5595 → 2.30.5618 Conversion * Updated zip code entries (#1063). * Updated word entries (#1068, #1069) Bug fix * Linux: Enabled switching to the DIRECT mode from the menu (#1061) * Linux: Enabled switching modes with Super+Space in Wayland (#853, #1059) * macOS: Fixed the limitation of mouse clicking on the renderer on macOS 15 (120bd93) * Windows: Fixed the setting of Omaha updater for the GoogleJapaneseInput build (#1072) Build * Android: Switched the Bazel rules from WORKSPACE to Bzlmod (#1002) * Android: Updated the Docker build environment * Linux: Update the build environment: Ubuntu 22.04 → 24.04 (#924) * macOS / Windows: Updated the Qt version: 6.7.2 → 6.7.3 (#1065) * Windows: Supported Bazel build (#948) * Windows: Updated the Wix version: 4.0.5 → 5.0.2 (#1070) Code * Performed code refactoring PiperOrigin-RevId: 684295272
|
Is this applied to the current Google Japanese Input Dev (GoogleJapaneseInput-2.30.5623.100+24.11.9)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is due to the fact that the wrong pronunciation for "般若心経" has been registered in the dictionary that the correction suggestion for "般若心経" appears even when you haven't typed "k" or "き" after "はんにゃしん".
mozc/src/data/dictionary_oss/reading_correction.tsv
Line 558 in ace3145
Issue IDs
Issue and/or discussion IDs related to this pull request.
Fixes #1060
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
Additional context
Add any other context about the pull request here.