-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify pipestream by correctly interrupting a read on context cancellation. #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llation. golang/go#20280 (comment) has an excellent example on how to interrupt a read on context cancellation, which means we don't need to set a read deadline on every read attempt. Then, the error handling is simplified, and as a side effect we aren't having spurious wakeups on idle fifos. This also means we no longer have a race on first read when the write end of a fifo isn't ready. Issue: #486
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Benchmark ResultBenchmark diff with base
|
4 tasks
This was referenced Mar 15, 2022
4 tasks
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang/go#20280 (comment) has an
excellent example on how to interrupt a read on context cancellation, which
means we don't need to set a read deadline on every read attempt. Then, the
error handling is simplified, and as a side effect we aren't having spurious
wakeups on idle fifos.
This also means we no longer have a race on first read when the write end of a
fifo isn't ready.
Issue: #486