Exit with 0 code when --one_shot is set #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 59.87% 59.87%
=======================================
Files 66 66
Lines 7222 7222
=======================================
Hits 4324 4324
Misses 2645 2645
Partials 253 253 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Benchmark ResultBenchmark diff with base |
|
Nice, I think the exit 1 should be inside the if statement just a few lines above. Can you add one there to exit 1 if the error is logged? |
jaqx0r
reviewed
Aug 26, 2021
This comment has been minimized.
This comment has been minimized.
I was able to use --one_shot to test mtail file syntax but ab3cbf2 added os.Exit(1) so I cannot use exit code to tell if a file is valid or not. Change exit code from 1 to 0, if there was a syntax error then earlier code will catch it.
jaqx0r
approved these changes
Aug 26, 2021
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
Unit Test Results 1 files 27 suites 20m 36s ⏱️ Results for commit 64be5cd. |
jaqx0r
added a commit
that referenced
this pull request
Feb 29, 2024
`prometheus/common` made a breaking change in `expfmt` with prometheus/common/#576 so we need to change the prometheus encoder constructor and the dependency version of both `common` and `client_golang` in the same PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to use --one_shot to test mtail file syntax but ab3cbf2 added os.Exit(1) so I cannot use exit code to tell if a file is valid or not.
Change exit code from 1 to 0, if there was a syntax error then earlier code will catch it.