Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

preparing for CI/CD #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

preparing for CI/CD #21

wants to merge 1 commit into from

Conversation

danacr
Copy link

@danacr danacr commented Aug 19, 2019

Since the repository requires local builds, I thought that implementing a pipeline would be a nice feature.

Copy link
Contributor

@jeffbyrnes jeffbyrnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile has a typo, and is missing the “r” in its name.

To fix:

git mv Dockefile Dockerfile
git add Dockerfile
git commit --amend
# Adjust commit message as-needed
git push --force origin master

and this PR will be updated without adding any additional commits, as if it was always named properly.

Copy link
Contributor

@jeffbyrnes jeffbyrnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! What are you thinking a CI/CD mechanism would do?

@danacr
Copy link
Author

danacr commented Aug 27, 2019

Seems good! What are you thinking a CI/CD mechanism would do?

either Google Cloud Build or Docker Hub build

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants